refactor: migrate ComposableController to @metamask/messenger (#6710)

## Explanation

<!--
Thanks for your contribution! Take a moment to answer these questions so
that reviewers have the information they need to properly understand
your changes:

* What is the current state of things and why does it need to change?
* What is the solution your changes offer and how does it work?
* Are there any changes whose purpose might not obvious to those
unfamiliar with the domain?
* If your primary goal was to update one package but you found you had
to update another one along the way, why did you do so?
* If you had to upgrade a dependency, why did you do so?
-->

## References

<!--
Are there any issues that this pull request is tied to?
Are there other links that reviewers should consult to understand these
changes better?
Are there client or consumer pull requests to adopt any breaking
changes?

For example:

* Fixes #12345
* Related to #67890
-->
* Related to #5626

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've communicated my changes to consumers by [updating changelogs
for packages I've
changed](https://github.com/MetaMask/core/tree/main/docs/contributing.md#updating-changelogs),
highlighting breaking changes as necessary
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Migrates `ComposableController` to `@metamask/messenger`, updates
types/metadata, rewrites tests, and updates dependencies and docs.
> 
> - **@metamask/composable-controller**:
> - Migrate from `RestrictedMessenger` to `Messenger`
(`@metamask/messenger`) and `@metamask/base-controller/next` APIs.
> - Update types: add `ComposableControllerActions/GetState`, refine
`ChildControllerStateChangeEvents`, and redefine
`ComposableControllerMessenger` to use `Messenger`.
> - Replace `anonymous` metadata with `includeInDebugSnapshot`; keep
`persist`, `includeInStateLogs`, `usedInUi`.
> - Use `messenger.subscribe` for child `stateChange` events with error
handling; minor cleanup.
> - Tests: rewrite to new messenger API and delegation; add case for
failed subscription; remove allowlist-dependent cases.
> - Add dependency `@metamask/messenger`; update TS project references.
>   - Changelog: document breaking changes and a typing fix.
> - **Docs/Graph**:
> - Add `composable_controller --> messenger`; add
`eip_7702_internal_rpc_middleware --> controller_utils` in README
mermaid graph.
> - **Tooling**:
>   - Adjust ESLint warning thresholds; update lockfile.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
17e9041. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
Co-authored-by: Salah-Eddine Saakoun <salah-eddine.saakoun@consensys.net>
Co-authored-by: Mark Stacey <markjstacey@gmail.com>

Author: 4 people

README.md

@@ -207,6 +207,7 @@ linkStyle default opacity:0.5
   chain_agnostic_permission --> network_controller;
   chain_agnostic_permission --> permission_controller;
   composable_controller --> base_controller;
+  composable_controller --> messenger;
   composable_controller --> json_rpc_engine;
   core_backend --> base_controller;
   core_backend --> controller_utils;

eslint-warning-thresholds.json

@@ -107,9 +107,6 @@
   "packages/composable-controller/src/ComposableController.test.ts": {
     "import-x/namespace": 3
   },
-  "packages/composable-controller/src/ComposableController.ts": {
-    "@typescript-eslint/no-unused-vars": 1
-  },
   "packages/controller-utils/jest.environment.js": {
     "n/prefer-global/text-encoder": 1,
     "n/prefer-global/text-decoder": 1,

packages/composable-controller/CHANGELOG.md

@@ -7,6 +7,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- **BREAKING:** Migrate `ComposableController` to new `Messenger` from `@metamask/messenger` ([#6710](https://github.com/MetaMask/core/pull/6710))
+  - Previously, the controller accepted a `RestrictedMessenger` instance from `@metamask/base-controller`.
+- **BREAKING:** Metadata property `anonymous` renamed to `includeInDebugSnapshot` ([#6710](https://github.com/MetaMask/core/pull/6710))
+
+### Fixed
+
+- Resolve incompatibility of `ChildControllerStateChangeEvents` type with `BaseController` (when used in the `Events` type argument of `ComposableControllerMessenger`) by removing unnecessary nested logic from definition ([#6904](https://github.com/MetaMask/core/pull/6904))
+  - Also update generic parameter names `ControllerName` and `ControllerState` to `ChildControllerName`, `ChildControllerState` for reduced ambiguity.
+
 ## [11.1.1]
 
 ### Changed

packages/composable-controller/package.json

@@ -47,7 +47,8 @@
     "test:watch": "NODE_OPTIONS=--experimental-vm-modules jest --watch"
   },
   "dependencies": {
-    "@metamask/base-controller": "^8.4.2"
+    "@metamask/base-controller": "^8.4.2",
+    "@metamask/messenger": "^0.3.0"
   },
   "devDependencies": {
     "@metamask/auto-changelog": "^3.4.4",