Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth-json-rpc-provider: Replace use of any with proper types (non-test files only) #3718

Open
Tracked by #3706
mcmire opened this issue Jan 4, 2024 · 2 comments
Open
Tracked by #3706

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 4, 2024

Look for the following string in non-test files to find these: // TODO: Replace `any` with type

At time of writing, there were 2 instances.

@MajorLift
Copy link
Contributor

MajorLift commented Jan 22, 2024

The any usage here occurs in the send and sendAsync methods of the SafeEventEmitterProvider class. Both methods are slated to be deprecated but not removed by this proposal (Align provider with Ethereum request libraries).

Therefore, we could replace the TODO annotations with something like the following and close this ticket:
// The any usage in this legacy type is being preserved for backward compatibility.

@MajorLift MajorLift assigned MajorLift and unassigned MajorLift Mar 10, 2024
@MajorLift
Copy link
Contributor

This can probably wait until the provider alignment proposal moves forward, and we can be certain that send/sendAsync will be sunsetted as legacy methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants