Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json-rpc-engine: Replace use of any with proper types (non-test files only) #3720

Closed
Tracked by #3706
mcmire opened this issue Jan 4, 2024 · 2 comments · Fixed by #3906
Closed
Tracked by #3706

json-rpc-engine: Replace use of any with proper types (non-test files only) #3720

mcmire opened this issue Jan 4, 2024 · 2 comments · Fixed by #3906
Assignees

Comments

@mcmire
Copy link
Contributor

mcmire commented Jan 4, 2024

Look for the following string in non-test files to find these: // TODO: Replace `any` with type

At time of writing, there were 6 instances.

@MajorLift
Copy link
Contributor

  • Completing this ticket will enable us to take full advantage of the type safety improvements that will be introduced by the provider alignment technical proposals.
  • All of the any usages in this package are for typing errors in catch blocks. These errors should mostly be aligned to JsonRpcEngineCallbackError.
  • serializeError() should only be used when sending an error via JSON-RPC. Otherwise, the information in unknown errors thrown by middleware should be preserved.

@MajorLift
Copy link
Contributor

MajorLift commented Feb 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants