Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[composable-controller] Fix incorrect #updateChildController behavior and improve typing #3907

Closed
MajorLift opened this issue Feb 7, 2024 · 0 comments · Fixed by #3904
Closed
Assignees

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Feb 7, 2024

There are several issues with the current ComposableController implementation that should be addressed before further updates are made to the controller (e.g. #3627).

  • Remove #controllers class field, which is not being updated by #updateChildController or anywhere else.
    • Removing this makes it clear that the list of child controllers to be composed is determined at class instantiation and cannot be altered later.
    • This behavior is consistent with #updateChildController being a private method.
  • Type BaseController, ComposableController state with Record<string, Json>
  • Add a isBaseController type guard.
    • Remove the deprecated subscribed property from BaseController.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant