Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-controller] Extract MessengerClient as parent class for BaseController and stateless non-controllers #4445

Open
MajorLift opened this issue Jun 21, 2024 · 0 comments
Assignees

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Jun 21, 2024

Explanation

Some of our classes that were previously labeled as controllers have empty state, making them non-controllers.

As part of Wallet Framework team's Q2 2024 OKRs (O3KR1), we're currently in the process of upgrading these non-controllers to use the messenger pattern without inheriting from BaseController.

To minimize redundant code, the reused portion of BaseController should be extracted into a new MessagingEndpoint (tentative) class that serves as a parent class to BaseController and all stateless non-controllers, and includes the logic a class needs in order to accept and use a messaging system.

We should ensure that both MessengerConsumer and BaseController are compatible as base classes for the polling-controller mixins.

References

@MajorLift MajorLift self-assigned this Aug 21, 2024
@MajorLift MajorLift changed the title [base-controller] Extract MessengerConsumer as parent class to BaseController and all stateless non-controllers [base-controller] Extract MessagingEndpoint as parent class for BaseController and stateless non-controllers Sep 5, 2024
@MajorLift MajorLift changed the title [base-controller] Extract MessagingEndpoint as parent class for BaseController and stateless non-controllers [base-controller] Extract MessengerClient as parent class for BaseController and stateless non-controllers Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant