You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SafeEventEmitterProvider is failing to send net_version requests correctly because it's using an empty object as the default params when none are provided.
While some methods do use an object for params, the vast majority use an array instead. Passing an empty object as the params for a method that has array parameters can result in failure (as is the case for net_version).
We should remove the default params altogether, or use an array as the default if we need to keep some default for some reason).
The
SafeEventEmitterProvider
is failing to sendnet_version
requests correctly because it's using an empty object as the default params when none are provided.While some methods do use an object for params, the vast majority use an array instead. Passing an empty object as the params for a method that has array parameters can result in failure (as is the case fornet_version
).We should remove the default params altogether, or use an array as the default if we need to keep some default for some reason).
The suspected culprit is this line: https://github.com/MetaMask/core/blob/main/packages/eth-json-rpc-provider/src/safe-event-emitter-provider.ts#L38
The text was updated successfully, but these errors were encountered: