Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Assets Controllers] Remove state scoped to the current chain #5166

Open
bergeron opened this issue Jan 16, 2025 · 1 comment · May be fixed by #5310
Open

[Assets Controllers] Remove state scoped to the current chain #5166

bergeron opened this issue Jan 16, 2025 · 1 comment · May be fixed by #5310

Comments

@bergeron
Copy link
Contributor

  • TokensController
  • TokenListController
  • AccountTrackerController

These controllers have some fields in their state scoped to the current chain, and other fields in their state keyed by chain id. The former is deprecated and should be removed in favor of querying state by chain id. Make sure all clients are using the per chain variants, deprecate the old fields, and remove any logic in the controllers that updates them.

@adonesky1
Copy link
Contributor

All of these controllers also have state that is keyed (and updated) by chainId which can simply be read instead.

@salimtb salimtb linked a pull request Feb 11, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants