You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This leads to problems when filtering logs using a mixed-case address. I believe that a .toLowerCase() is all that's required to fix this bug. In the meantime, the workaround is for developers to specify contract addresses in all lowercase.
This is potentially one thing leading to #2 and MetaMask/metamask-extension#2393, but the main issue in the latter appears to be more about the timing, lifecycle, and interaction of various objects (providers, block trackers and filter middlewares).
The text was updated successfully, but these errors were encountered:
smarx
changed the title
incorrect case-sensitive comparison for address
incorrect case-sensitive comparison for addresses
Dec 13, 2017
Address comparisons should be case-insensitive, but the comparison here is case-sensitive:
https://github.com/kumavis/eth-json-rpc-filters/blob/fa163bc215044221656bc8e5a29569ee5013d27f/log-filter.js#L68
This leads to problems when filtering logs using a mixed-case address. I believe that a
.toLowerCase()
is all that's required to fix this bug. In the meantime, the workaround is for developers to specify contract addresses in all lowercase.This is potentially one thing leading to #2 and MetaMask/metamask-extension#2393, but the main issue in the latter appears to be more about the timing, lifecycle, and interaction of various objects (providers, block trackers and filter middlewares).
The text was updated successfully, but these errors were encountered: