Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect case-sensitive comparison for addresses #4

Closed
smarx opened this issue Dec 13, 2017 · 1 comment
Closed

incorrect case-sensitive comparison for addresses #4

smarx opened this issue Dec 13, 2017 · 1 comment

Comments

@smarx
Copy link

smarx commented Dec 13, 2017

Address comparisons should be case-insensitive, but the comparison here is case-sensitive:

https://github.com/kumavis/eth-json-rpc-filters/blob/fa163bc215044221656bc8e5a29569ee5013d27f/log-filter.js#L68

This leads to problems when filtering logs using a mixed-case address. I believe that a .toLowerCase() is all that's required to fix this bug. In the meantime, the workaround is for developers to specify contract addresses in all lowercase.

This is potentially one thing leading to #2 and MetaMask/metamask-extension#2393, but the main issue in the latter appears to be more about the timing, lifecycle, and interaction of various objects (providers, block trackers and filter middlewares).

@smarx smarx changed the title incorrect case-sensitive comparison for address incorrect case-sensitive comparison for addresses Dec 13, 2017
@kumavis
Copy link
Member

kumavis commented Dec 21, 2017

Thanks! fixed in 1.2.5

@kumavis kumavis closed this as completed Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants