Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware should ideally have a name attribute #8

Open
danfinlay opened this issue May 30, 2019 · 0 comments
Open

Middleware should ideally have a name attribute #8

danfinlay opened this issue May 30, 2019 · 0 comments
Labels
team-wallet-framework

Comments

@danfinlay
Copy link

This middleware does not result in a named object once assigned to the engine, making it harder to identify & cleanup listeners when a connection is closed, as I had to somewhat hack here:
https://github.com/MetaMask/metamask-extension/pull/6670/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@desi @danfinlay