Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle different edit distance "steps". #2060

Closed
blurpesec opened this issue Jul 11, 2018 · 1 comment
Closed

Handle different edit distance "steps". #2060

blurpesec opened this issue Jul 11, 2018 · 1 comment
Labels
enhancement

Comments

@blurpesec
Copy link
Contributor

blurpesec commented Jul 11, 2018 •
edited
Loading

Handle dynamic edit distance based on length of input domain

For example:

Domain input myetherwallet.com is 17 characters long. Since it is so long, it's okay to use a larger edit distance than mycrypto.com which is only 11 characters long.

Suggested:

Handle inputdomain.length > 11 with an edit distance of 2.
If inputdomain.length <= 11, handle with an edit distance of 1.
If inputdomain.length >= 15, handle with an edit distance of 3.

This should return more-accurate results.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extends the module's outputs blurpesec/eth-phishing-detect
4 participants
@bdresser @gravelcycles @blurpesec @FoxxyMartin