Skip to content
This repository has been archived by the owner on Oct 7, 2024. It is now read-only.

Update trezor connect dependency: auto-closing of popup mitigation #187

Open
sime opened this issue Sep 8, 2023 · 2 comments
Open

Update trezor connect dependency: auto-closing of popup mitigation #187

sime opened this issue Sep 8, 2023 · 2 comments

Comments

@sime
Copy link
Contributor

sime commented Sep 8, 2023

Auto closing popup

The following change in Trezor Connect 9.1.1 introduces a mitigation about the auto-closing of popups.

feat(connect-popup): when a call to TrezorConnect returns success: false popup remains opened and displays error page instead.

This is driven by the client, and requires an NPM upgrade. This is an ongoing issue and MetaMask users are still experiencing it.

The goal is users will be able to report which errors are occurring.

Missing package are now available

Patches like this can be removed. Since the missing dependency is available on npm.

Screenshot

image (1)

@Hannsek
Copy link

Hannsek commented Sep 22, 2023

Hello, are there any plans on solving this?

@sime
Copy link
Contributor Author

sime commented Nov 26, 2023

Somewhat related issue: MetaMask/metamask-extension#12967 (comment)

Currently, if a wrong passphrase is entered, the popup will close without providing any feedback to the user. Updating @trezor/connect should resolve this.

cc: @plasmacorral

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants