You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
chore: fixing centrano1 font name in token by removing space (#522)
## **Description**
This PR standardizes the font family name to "CentraNo1" (without space)
across design tokens to align with Mobile and Extension implementations.
1. Reason for change: There was an inconsistency where Portfolio used
"Centra No1" (with space) while Mobile and Extension used "CentraNo1"
(without space). This inconsistency caused the design tokens to display
incorrectly.
2. Improvement: Consolidates all references to use "CentraNo1" without
space, matching the Mobile and Extension implementation, which fixes the
font display in design tokens and ensures consistency across platforms.
## **Related issues**
Fixes: Cross-platform font family name inconsistency causing display
issues in design tokens
## **Manual testing steps**
1. Verify font family name is "CentraNo1" (without space) in:
- CSS variables (`--font-family-sans`)
- Storybook documentation
- Typography tokens
2. Confirm font renders correctly in design token examples
3. Verify changes align with existing Mobile and Extension
implementations
## **Screenshots/Recordings**
### **Before**
- Mobile/Extension: `"CentraNo1"` (correct)
- Portfolio: `"Centra No1"` (inconsistent)
- Design Tokens: Mixed usage causing display issues
<img width="1510" alt="Screenshot 2025-03-27 at 11 14 01 AM"
src="https://github.com/user-attachments/assets/7997f5cf-a466-4c50-a629-9c8031c175aa"
/>
### **After**
Consistent usage across all platforms:
```css
--font-family-sans: 'CentraNo1', 'Helvetica Neue', Helvetica, Arial, sans-serif;
```
<img width="1509" alt="Screenshot 2025-03-27 at 11 13 11 AM"
src="https://github.com/user-attachments/assets/0ad7a106-0329-4b21-ba63-ea7b35aa871a"
/>
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs)
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Copy file name to clipboardExpand all lines: packages/design-tokens/CHANGELOG.md
+3-3Lines changed: 3 additions & 3 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,11 +11,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
11
11
12
12
### Changed
13
13
14
-
-**BREAKING:** Replaced Euclid Circular B with Centra No1 as the primary font family ([#499](https://github.com/MetaMask/metamask-design-system/pull/499)). See the [migration guide](./MIGRATION.md#from-version-510-to-600) for details.
14
+
-**BREAKING:** Replaced Euclid Circular B with CentraNo1 as the primary font family ([#499](https://github.com/MetaMask/metamask-design-system/pull/499)). See the [migration guide](./MIGRATION.md#from-version-510-to-600) for details.
15
15
16
16
- Removed `--font-family-euclid-circular-b` and `--font-family-roboto` CSS variables
17
-
- Changed `--font-family-sans` to use Centra No1 with updated fallback chain
18
-
- Updated font files from Euclid Circular B to Centra No1 (where 'Book' is the 400 weight variant)
17
+
- Changed `--font-family-sans` to use CentraNo1 with updated fallback chain
18
+
- Updated font files from Euclid Circular B to CentraNo1 (where 'Book' is the 400 weight variant)
19
19
- Applications using the design system will need to update font imports and references
Copy file name to clipboardExpand all lines: packages/design-tokens/MIGRATION.md
+6-6Lines changed: 6 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -11,7 +11,7 @@ This guide provides detailed instructions for migrating your project from one ve
11
11
12
12
### Font Family Changes (Breaking Changes)
13
13
14
-
In version 6.0.0, we've completely replaced Euclid Circular B with Centra No1 as our primary font family. This is a breaking change that affects both web and React Native applications.
14
+
In version 6.0.0, we've completely replaced Euclid Circular B with CentraNo1 as our primary font family. This is a breaking change that affects both web and React Native applications.
15
15
16
16
#### CSS Changes
17
17
@@ -29,7 +29,7 @@ In version 6.0.0, we've completely replaced Euclid Circular B with Centra No1 as
0 commit comments