Skip to content

Commit 352687b

Browse files
committed
further simplify
1 parent f0abd5b commit 352687b

File tree

1 file changed

+11
-12
lines changed

1 file changed

+11
-12
lines changed

ui/pages/routes/confirmation-handler.tsx

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import {
1515
ENVIRONMENT_TYPE_NOTIFICATION,
1616
ENVIRONMENT_TYPE_FULLSCREEN,
1717
SNAP_MANAGE_ACCOUNTS_CONFIRMATION_TYPES,
18-
ORIGIN_METAMASK,
19-
SMART_TRANSACTION_CONFIRMATION_TYPES,
18+
// ORIGIN_METAMASK,
19+
// SMART_TRANSACTION_CONFIRMATION_TYPES,
2020
} from '../../../shared/constants/app';
2121
import {
2222
selectHasApprovalFlows,
@@ -96,20 +96,19 @@ export const ConfirmationHandler = () => {
9696
]);
9797

9898
// Flows that *should* navigate in fullscreen, based on E2E specs
99-
const hasSnapApproval = pendingApprovals.some((approval) =>
99+
const hasAllowedPopupRedirectApprovals = pendingApprovals.some((approval) =>
100100
SNAP_APPROVAL_TYPES.includes(approval.type),
101101
);
102102

103103
// Flows that *should not* navigate in fullscreen, based on E2E specs
104-
const hasSmartTransactionStatus = pendingApprovals.some(
105-
(approval) =>
106-
approval.type ===
107-
SMART_TRANSACTION_CONFIRMATION_TYPES.showSmartTransactionStatusPage &&
108-
approval.origin?.toLowerCase() !== ORIGIN_METAMASK,
109-
);
110-
111-
const skipHandler =
112-
isFullscreen && (hasSmartTransactionStatus || !hasSnapApproval);
104+
// const hasSmartTransactionStatus = pendingApprovals.some(
105+
// (approval) =>
106+
// approval.type ===
107+
// SMART_TRANSACTION_CONFIRMATION_TYPES.showSmartTransactionStatusPage &&
108+
// approval.origin?.toLowerCase() !== ORIGIN_METAMASK,
109+
// );
110+
111+
const skipHandler = isFullscreen && !hasAllowedPopupRedirectApprovals;
113112

114113
useEffect(() => {
115114
// Only run when on home/default page (for now)

0 commit comments

Comments
 (0)