fix: simulation of type-4 transactions (#31335)

Fix balance change simulation of type-4 transactions by bumping
`@metamask/transaction-controller` to `52.3.0`.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/31335?quickstart=1)

Fixes:
[#4506](MetaMask/MetaMask-planning#4506)

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

Author: matthewwalsh0

package.json

@@ -322,7 +322,7 @@
     "@metamask/snaps-sdk": "^6.21.0",
     "@metamask/snaps-utils": "^9.1.0",
     "@metamask/solana-wallet-snap": "^1.15.1",
-    "@metamask/transaction-controller": "^52.2.0",
+    "@metamask/transaction-controller": "^52.3.0",
     "@metamask/user-operation-controller": "^24.0.1",
     "@metamask/utils": "^11.1.0",
     "@ngraveio/bc-ur": "^1.1.12",

test/e2e/tests/transaction/incoming-transactions.spec.ts

@@ -1,4 +1,5 @@
 import { Mockttp } from 'mockttp';
+import { TransactionType } from '@metamask/transaction-controller';
 import { loginWithoutBalanceValidation } from '../../page-objects/flows/login.flow';
 import { Driver } from '../../webdriver/driver';
 import { DEFAULT_FIXTURE_ACCOUNT } from '../../constants';
@@ -174,6 +175,7 @@ describe('Incoming Transactions', function () {
             {
               hash: RESPONSE_STANDARD_MOCK.hash,
               txParams: { from: RESPONSE_STANDARD_MOCK.from },
+              type: TransactionType.incoming,
             },
           ])
           .build(),

yarn.lock

@@ -6594,9 +6594,9 @@ __metadata:
   languageName: node
   linkType: hard
 
-"@metamask/transaction-controller@npm:^52.2.0":
-  version: 52.2.0
-  resolution: "@metamask/transaction-controller@npm:52.2.0"
+"@metamask/transaction-controller@npm:^52.3.0":
+  version: 52.3.0
+  resolution: "@metamask/transaction-controller@npm:52.3.0"
   dependencies:
     "@ethereumjs/common": "npm:^4.4.0"
     "@ethereumjs/tx": "npm:^5.4.0"
@@ -6626,7 +6626,7 @@ __metadata:
     "@metamask/gas-fee-controller": ^23.0.0
     "@metamask/network-controller": ^23.0.0
     "@metamask/remote-feature-flag-controller": ^1.5.0
-  checksum: 10/2a2b08c5d19410a69cf3fd29819d7928e91c3d9fe59b1b29a12ff62ddebacadcb3dc4710e54860571230f95ed17c57fc6876d85fcfbc6d6b21e22d868a47cb92
+  checksum: 10/0d73d0734a0ecdf8715e55639595b460bd98e3f719702356636a39ff4f5d1179050c236d412408ab799af2a202f14fcc934fd9bd6dbd9e747f3ea8b6ce51273b
   languageName: node
   linkType: hard
 
@@ -27386,7 +27386,7 @@ __metadata:
     "@metamask/test-bundler": "npm:^1.0.0"
     "@metamask/test-dapp": "npm:9.2.0"
     "@metamask/test-dapp-multichain": "npm:^0.6.0"
-    "@metamask/transaction-controller": "npm:^52.2.0"
+    "@metamask/transaction-controller": "npm:^52.3.0"
     "@metamask/user-operation-controller": "npm:^24.0.1"
     "@metamask/utils": "npm:^11.1.0"
     "@ngraveio/bc-ur": "npm:^1.1.12"