Skip to content

Commit 3cb1b25

Browse files
digiwanddigiwand
committed
fix: e2e tests should test old signatures until flag is removed
1 parent 20fdcd6 commit 3cb1b25

File tree

7 files changed

+71
-1
lines changed

7 files changed

+71
-1
lines changed

‎test/e2e/accounts/common.ts‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ export const accountSnapFixtures = (title: string | undefined) => {
3434
disabledRpcMethodPreferences: {
3535
eth_sign: true,
3636
},
37+
preferences: {
38+
redesignedConfirmationsEnabled: false,
39+
},
3740
})
3841
.build(),
3942
ganacheOptions: multipleGanacheOptions,

‎test/e2e/accounts/snap-account-signatures-and-disconnects.spec.ts‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ describe('Snap Account Signatures and Disconnects', function (this: Suite) {
1515
await withFixtures(
1616
{
1717
dapp: true,
18-
fixtures: new FixtureBuilder().build(),
18+
fixtures: new FixtureBuilder()
19+
.withPreferencesController({
20+
preferences: {
21+
redesignedConfirmationsEnabled: false,
22+
},
23+
})
24+
.build(),
1925
ganacheOptions: multipleGanacheOptions,
2026
title: this.test?.fullTitle(),
2127
},

‎test/e2e/tests/dapp-interactions/signin-with-ethereum.spec.js‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,11 @@ describe('Sign in with ethereum', function () {
2222
dapp: true,
2323
fixtures: new FixtureBuilder()
2424
.withPermissionControllerConnectedToTestDapp()
25+
.withPreferencesController({
26+
preferences: {
27+
redesignedConfirmationsEnabled: false,
28+
},
29+
})
2530
.build(),
2631
ganacheOptions: defaultGanacheOptions,
2732
title: this.test.fullTitle(),

‎test/e2e/tests/petnames/petnames-signatures.spec.js‎

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,11 @@ describe('Petnames - Signatures', function () {
101101
dapp: true,
102102
fixtures: new FixtureBuilder()
103103
.withPermissionControllerConnectedToTestDapp()
104+
.withPreferencesController({
105+
preferences: {
106+
redesignedConfirmationsEnabled: false,
107+
},
108+
})
104109
.withNoNames()
105110
.build(),
106111
ganacheOptions: defaultGanacheOptions,
@@ -137,6 +142,11 @@ describe('Petnames - Signatures', function () {
137142
dapp: true,
138143
fixtures: new FixtureBuilder()
139144
.withPermissionControllerConnectedToTestDapp()
145+
.withPreferencesController({
146+
preferences: {
147+
redesignedConfirmationsEnabled: false,
148+
},
149+
})
140150
.withNoNames()
141151
.build(),
142152
ganacheOptions: defaultGanacheOptions,
@@ -178,6 +188,11 @@ describe('Petnames - Signatures', function () {
178188
dapp: true,
179189
fixtures: new FixtureBuilder()
180190
.withPermissionControllerConnectedToTestDapp()
191+
.withPreferencesController({
192+
preferences: {
193+
redesignedConfirmationsEnabled: false,
194+
},
195+
})
181196
.withNoNames()
182197
.build(),
183198
ganacheOptions: defaultGanacheOptions,

‎test/e2e/tests/signature/eth-sign.spec.js‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,11 @@ describe('Eth sign', function () {
1717
dapp: true,
1818
fixtures: new FixtureBuilder()
1919
.withPermissionControllerConnectedToTestDapp()
20+
.withPreferencesController({
21+
preferences: {
22+
redesignedConfirmationsEnabled: false,
23+
},
24+
})
2025
.build(),
2126
ganacheOptions: defaultGanacheOptions,
2227
title: this.test.fullTitle(),
@@ -49,6 +54,9 @@ describe('Eth sign', function () {
4954
disabledRpcMethodPreferences: {
5055
eth_sign: true,
5156
},
57+
preferences: {
58+
redesignedConfirmationsEnabled: false,
59+
},
5260
})
5361
.withPermissionControllerConnectedToTestDapp()
5462
.build(),
@@ -103,6 +111,9 @@ describe('Eth sign', function () {
103111
disabledRpcMethodPreferences: {
104112
eth_sign: true,
105113
},
114+
preferences: {
115+
redesignedConfirmationsEnabled: false,
116+
},
106117
})
107118
.withPermissionControllerConnectedToTestDapp()
108119
.build(),

‎test/e2e/tests/signature/personal-sign.spec.js‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,11 @@ describe('Personal sign', function () {
1616
dapp: true,
1717
fixtures: new FixtureBuilder()
1818
.withPermissionControllerConnectedToTestDapp()
19+
.withPreferencesController({
20+
preferences: {
21+
redesignedConfirmationsEnabled: false,
22+
},
23+
})
1924
.build(),
2025
ganacheOptions: defaultGanacheOptions,
2126
title: this.test.fullTitle(),
@@ -53,6 +58,11 @@ describe('Personal sign', function () {
5358
dapp: true,
5459
fixtures: new FixtureBuilder()
5560
.withPermissionControllerConnectedToTestDapp()
61+
.withPreferencesController({
62+
preferences: {
63+
redesignedConfirmationsEnabled: false,
64+
},
65+
})
5666
.build(),
5767
ganacheOptions: defaultGanacheOptions,
5868
title: this.test.fullTitle(),

‎test/e2e/tests/signature/signature-request.spec.js‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,11 @@ describe('Sign Typed Data Signature Request', function () {
6969
dapp: true,
7070
fixtures: new FixtureBuilder()
7171
.withPermissionControllerConnectedToTestDapp()
72+
.withPreferencesController({
73+
preferences: {
74+
redesignedConfirmationsEnabled: false,
75+
},
76+
})
7277
.build(),
7378
ganacheOptions: defaultGanacheOptions,
7479
title: this.test.fullTitle(),
@@ -129,6 +134,11 @@ describe('Sign Typed Data Signature Request', function () {
129134
dapp: true,
130135
fixtures: new FixtureBuilder()
131136
.withPermissionControllerConnectedToTestDapp()
137+
.withPreferencesController({
138+
preferences: {
139+
redesignedConfirmationsEnabled: false,
140+
},
141+
})
132142
.build(),
133143
ganacheOptions: defaultGanacheOptions,
134144
title: this.test.fullTitle(),
@@ -206,6 +216,11 @@ describe('Sign Typed Data Signature Request', function () {
206216
dapp: true,
207217
fixtures: new FixtureBuilder()
208218
.withPermissionControllerConnectedToTestDapp()
219+
.withPreferencesController({
220+
preferences: {
221+
redesignedConfirmationsEnabled: false,
222+
},
223+
})
209224
.build(),
210225
ganacheOptions: defaultGanacheOptions,
211226
title: this.test.fullTitle(),
@@ -257,6 +272,11 @@ describe('Sign Typed Data Signature Request', function () {
257272
dapp: true,
258273
fixtures: new FixtureBuilder()
259274
.withPermissionControllerConnectedToTestDapp()
275+
.withPreferencesController({
276+
preferences: {
277+
redesignedConfirmationsEnabled: false,
278+
},
279+
})
260280
.build(),
261281
ganacheOptions: defaultGanacheOptions,
262282
title: this.test.fullTitle(),

0 commit comments

Comments
 (0)