fixed global menu alignment

Author: NidhiKJha

app/images/icons/popup.svg

@@ -201,6 +201,7 @@ export enum IconName {
   Plug = 'plug',
   PlusAndMinus = 'plus-and-minus',
   PolicyAlert = 'policy-alert',
+  Popup = 'popup',
   Print = 'print',
   PriorityHigh = 'priority-high',
   PrivacyTip = 'privacy-tip',

ui/components/component-library/icon/icon.types.ts

@@ -338,6 +338,11 @@ export const GlobalMenu = ({
           </MenuItem>
         </>
       )}
+      <Box
+        borderColor={BorderColor.borderMuted}
+        width={BlockSize.Full}
+        style={{ height: '1px', borderBottomWidth: 0 }}
+      ></Box>
       {rewardsEnabled && (
         <DiscoverMenuItem
           metricsLocation={METRICS_LOCATION}
@@ -394,35 +399,13 @@ export const GlobalMenu = ({
         width={BlockSize.Full}
         style={{ height: '1px', borderBottomWidth: 0 }}
       ></Box>
-      <MenuItem
-        to={
-          isGatorPermissionsRevocationFeatureEnabled()
-            ? GATOR_PERMISSIONS
-            : PERMISSIONS
-        }
-        iconName={IconName.SecurityTick}
-        onClick={() => {
-          trackEvent({
-            event: MetaMetricsEventName.NavPermissionsOpened,
-            category: MetaMetricsEventCategory.Navigation,
-            properties: {
-              location: METRICS_LOCATION,
-            },
-          });
-          closeMenu();
-        }}
-        data-testid="global-menu-connected-sites"
-        disabled={hasUnapprovedTransactions}
-      >
-        {t('allPermissions')}
-      </MenuItem>
       {/* Toggle between popup and sidepanel - only for Chrome when sidepanel is enabled */}
       {getBrowserName() !== PLATFORM_FIREFOX &&
         isSidePanelEnabled &&
         (getEnvironmentType() === ENVIRONMENT_TYPE_POPUP ||
           getEnvironmentType() === ENVIRONMENT_TYPE_SIDEPANEL) && (
           <MenuItem
-            iconName={IconName.Sidepanel}
+            iconName={isSidePanelDefault ? IconName.Popup : IconName.Sidepanel}
             onClick={async () => {
               await toggleDefaultView();
               trackEvent({
@@ -442,6 +425,28 @@ export const GlobalMenu = ({
             {isSidePanelDefault ? t('switchToPopup') : t('switchToSidePanel')}
           </MenuItem>
         )}
+      <MenuItem
+        to={
+          isGatorPermissionsRevocationFeatureEnabled()
+            ? GATOR_PERMISSIONS
+            : PERMISSIONS
+        }
+        iconName={IconName.SecurityTick}
+        onClick={() => {
+          trackEvent({
+            event: MetaMetricsEventName.NavPermissionsOpened,
+            category: MetaMetricsEventCategory.Navigation,
+            properties: {
+              location: METRICS_LOCATION,
+            },
+          });
+          closeMenu();
+        }}
+        data-testid="global-menu-connected-sites"
+        disabled={hasUnapprovedTransactions}
+      >
+        {t('allPermissions')}
+      </MenuItem>
       <MenuItem
         data-testid="global-menu-networks"
         iconName={IconName.Hierarchy}