Fix tests and linting

Author: matthewwalsh0

app/scripts/constants/sentry-state.ts

@@ -60,6 +60,8 @@ export const SENTRY_BACKGROUND_STATE = {
     onboardingDate: false,
     currentExtensionPopupId: false,
     defaultHomeActiveTabName: true,
+    enableEnforcedSimulations: true,
+    enableEnforcedSimulationsForTransactions: false,
     fullScreenGasPollTokens: true,
     // TODO: Fix in https://github.com/MetaMask/metamask-extension/issues/31860
     // eslint-disable-next-line @typescript-eslint/naming-convention

shared/types/background.ts

@@ -134,6 +134,8 @@ export type ControllerStatePropertiesEnumerated = {
   updateModalLastDismissedAt: AppStateControllerState['updateModalLastDismissedAt'];
   lastUpdatedAt: AppStateControllerState['lastUpdatedAt'];
   throttledOrigins: AppStateControllerState['throttledOrigins'];
+  enableEnforcedSimulations: AppStateControllerState['enableEnforcedSimulations'];
+  enableEnforcedSimulationsForTransactions: AppStateControllerState['enableEnforcedSimulationsForTransactions'];
   quoteRequest: BridgeControllerState['quoteRequest'];
   quotes: BridgeControllerState['quotes'];
   quotesInitialLoadTime: BridgeControllerState['quotesInitialLoadTime'];

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json

@@ -58,7 +58,9 @@
     "switchedNetworkDetails": null,
     "currentExtensionPopupId": "number",
     "termsOfUseLastAgreed": "number",
-    "snapsInstallPrivacyWarningShown": true
+    "snapsInstallPrivacyWarningShown": true,
+    "enableEnforcedSimulations": true,
+    "enableEnforcedSimulationsForTransactions": "object"
   },
   "ApprovalController": {
     "pendingApprovals": "object",

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-ui-state.json

@@ -370,7 +370,9 @@
     "encryptionKey": "string",
     "encryptionSalt": "string",
     "socialBackupsMetadata": "object",
-    "srpSessionData": "object"
+    "srpSessionData": "object",
+    "enableEnforcedSimulations": true,
+    "enableEnforcedSimulationsForTransactions": "object"
   },
   "ramps": "object",
   "send": "object",

test/integration/data/onboarding-completion-route.json

@@ -86,6 +86,8 @@
   "detectedTokens": [],
   "dismissSeedBackUpReminder": false,
   "domains": {},
+  "enableEnforcedSimulations": "boolean",
+  "enableEnforcedSimulationsForTransactions": "object",
   "enableMV3TimestampSave": true,
   "enabledNetworkMap": {
     "eip155": {

ui/pages/confirmations/hooks/transactions/useIsEnforcedSimulationsSupported.test.ts

@@ -39,6 +39,10 @@ function renderHook({
 }
 
 describe('useIsEnforcedSimulationsSupported', () => {
+  beforeEach(() => {
+    process.env.ENABLE_ENFORCED_SIMULATIONS = true as never;
+  });
+
   it('returns true if supported', () => {
     const { result } = renderHook();
     expect(result.current).toBe(true);

ui/pages/confirmations/selectors/confirm.test.ts

@@ -39,6 +39,8 @@ describe('confirm selectors', () => {
         },
       },
       approvalFlows: [],
+      enableEnforcedSimulations: false,
+      enableEnforcedSimulationsForTransactions: {},
     },
   };