Skip to content

Commit 54fd624

Browse files
bergarcesGudahtt
andauthored
fix: update package to avoid yarn audit issue (#38348)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Resolve `node-forge` to ^1.3.2 in order to pass the audit. DO NOT MERGE unless someone with security privileges clears it. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/38348?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates node-forge to 1.3.2 and stabilizes E2E by adding/using a safe handler for the backup reminder modal. > > - **Dependencies**: > - Bump `node-forge` to `1.3.2` in `yarn.lock`. > - **Tests (E2E)**: > - `test/e2e/page-objects/pages/home/homepage.ts`: add `clickBackupRemindMeLaterButtonSafe` using `clickElementSafe`. > - Use the safe backup reminder handler in `tests/account/incremental-security.spec.ts` and `tests/settings/change-password.spec.ts` to proceed past the reminder. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 846d2a1. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: Mark Stacey <mark.stacey@consensys.net>
1 parent f167e26 commit 54fd624

File tree

4 files changed

+12
-3
lines changed

4 files changed

+12
-3
lines changed

test/e2e/page-objects/pages/home/homepage.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,10 @@ class HomePage {
196196
);
197197
}
198198

199+
async clickBackupRemindMeLaterButtonSafe(): Promise<void> {
200+
await this.driver.clickElementSafe(this.backupRemindMeLaterButton);
201+
}
202+
199203
async closeSurveyToast(surveyName: string): Promise<void> {
200204
console.log(`Close survey toast for ${surveyName}`);
201205
await this.driver.waitForSelector({

test/e2e/tests/account/incremental-security.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,8 @@ describe('Incremental Security', function (this: Suite) {
9696
// copy the wallet address
9797
const homePage = new HomePage(driver);
9898
await homePage.checkPageIsLoaded();
99+
// TODO: This is a temporary fix to unblock CI. Remove this once the issue is fixed.
100+
await homePage.clickBackupRemindMeLaterButtonSafe();
99101
await homePage.headerNavbar.clickAddressCopyButton();
100102

101103
// switched to Dapp and send eth to the current account

test/e2e/tests/settings/change-password.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,9 @@ describe('Change wallet password', function () {
7373
const homePage = new HomePage(driver);
7474
await homePage.checkPageIsLoaded();
7575

76+
// TODO: This is a temporary fix to unblock CI. Remove this once the issue is fixed.
77+
await homePage.clickBackupRemindMeLaterButtonSafe();
78+
7679
await doPasswordChangeAndLockWallet(driver, OLD_PASSWORD, NEW_PASSWORD);
7780

7881
const loginPage = new LoginPage(driver);

yarn.lock

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34217,9 +34217,9 @@ __metadata:
3421734217
linkType: hard
3421834218

3421934219
"node-forge@npm:^1, node-forge@npm:^1.2.1":
34220-
version: 1.3.1
34221-
resolution: "node-forge@npm:1.3.1"
34222-
checksum: 10/05bab6868633bf9ad4c3b1dd50ec501c22ffd69f556cdf169a00998ca1d03e8107a6032ba013852f202035372021b845603aeccd7dfcb58cdb7430013b3daa8d
34220+
version: 1.3.2
34221+
resolution: "node-forge@npm:1.3.2"
34222+
checksum: 10/dcc54aaffe0cf52367214a20c0032aa9b209d9095dd14526504f1972d1900a07e96046b3684cb0c8d0cc3d48744dd18e02b7b447ab28fac615ffb850beeabf18
3422334223
languageName: node
3422434224
linkType: hard
3422534225

0 commit comments

Comments
 (0)