Skip to content

Commit 86aee85

Browse files
smgvmetamaskbotchaitanyapottiMajorLift
authored
feat: updated wallet ready page PR - 2 (#36839)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> In this pull request, we have updated the wallet-ready page. Specifically, we have replaced the "Remind Me Later" UI with the content on the wallet-ready page. Changes include removing all previous content and replacing it with a simple title—Your wallet is ready. Additionally, we introduced a Rive animation loader and positioned the "Manage Settings" text button below the "Done" button. Jira Link: https://consensyssoftware.atlassian.net/browse/SL-54 Figma Link: https://www.figma.com/design/pViOUcmjwhEzFsdrwknpNc/Onboarding?node-id=16495-182046&m=dev [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/36839?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: we have updated the wallet-ready page ## **Related issues** Fixes: ## **Manual testing steps** 1. Open the extension. 2. Follow any flow for creating a wallet. 3. At the end of the onboarding flow, validate the changes against the provided Figma link. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> https://github.com/user-attachments/assets/5140ac6f-7347-4f18-beb9-8cc5c75f5db9 <img width="1725" height="986" alt="Screenshot 2025-10-14 at 5 46 17 PM" src="https://github.com/user-attachments/assets/10517def-1179-44f0-953e-51ea135f30a8" /> https://github.com/user-attachments/assets/1297d657-acbf-4d52-bc39-54415368d17c https://github.com/user-attachments/assets/073a2e71-c877-4552-a7e7-271bd095d532 Fixed Word Wrap in Review SRP UI: <img width="754" height="956" alt="Screenshot 2025-10-15 at 3 42 36 PM" src="https://github.com/user-attachments/assets/092e8733-8019-4cd3-9e9f-ac20c05403e6" /> <img width="728" height="856" alt="Screenshot 2025-10-15 at 3 48 58 PM" src="https://github.com/user-attachments/assets/9ea6d33e-4137-4edd-a6e9-d2221043d82c" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Reworks the wallet-ready page with a new Rive animation and streamlined UI, introduces a shared Rive WASM context, and consolidates SRP copy/locales; updates headers, styles, and tests accordingly. > > - **Onboarding UI**: > - **Wallet Ready**: Simplifies `creation-successful` to show title `"Your wallet is ready!"`, a Rive animation (`WalletReadyAnimation`), a primary `Done` button, and a text "Manage default settings" button below. > - Conditional SRP-backup-from-settings path retains explanatory text and settings action. > - Hides header banner on `ONBOARDING_COMPLETION_ROUTE` when arriving from SRP backup/reminder. > - Removes prior “Remind me later” and social-login variants. > - **Rive Animations Infrastructure**: > - Adds `ui/contexts/rive-wasm` with hooks (`useRiveWasmReady`, `useRiveWasmFile`) and provider; wraps app in `RiveWasmProvider` (`ui/pages/index.js`). > - Refactors `fox-appear-animation.tsx` and `metamask-wordmark-animation.tsx` to use the shared context/file-loading; removes `ui/pages/onboarding-flow/rive-wasm/*` init. > - Adds `wallet-ready-animation.tsx` and related styles (`index.scss`). > - **i18n**: > - Inlines SRP warning into `seedPhraseReviewDetails` and removes `seedPhraseReviewDetails2` across locales. > - Removes unused `walletReady*` reminder/social strings; keeps `yourWalletIsReady` and `yourWalletIsReadyFromReminder`. > - **Tests/E2E**: > - Updates unit/e2e tests and page objects to match new UI and animations; adjusts snapshots for inlined SRP copy. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 31f1143. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com> Co-authored-by: chaitanyapotti <chaitanya.potti@gmail.com> Co-authored-by: Jongsun Suh <jongsun.suh@icloud.com>
1 parent 2cfcf7d commit 86aee85

34 files changed

+513
-821
lines changed

app/_locales/de/messages.json

Lines changed: 1 addition & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/el/messages.json

Lines changed: 1 addition & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en/messages.json

Lines changed: 2 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/en_GB/messages.json

Lines changed: 2 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/es/messages.json

Lines changed: 1 addition & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/fr/messages.json

Lines changed: 1 addition & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/_locales/ga/messages.json

Lines changed: 1 addition & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)