Skip to content

Commit 890e73b

Browse files
runway-github[bot]jeffsmale90metamaskbot
authored
release(runway): cherry-pick fix: advanced permissions requests for mainnet failing cp-13.9.0 (#37678)
- fix: advanced permissions requests for mainnet failing cp-13.9.0 (#37675) ## **Description** Upgrades @metamask/gator-permissions-snap from `^0.6.0` to `^0.6.1` - Corrects Accounts API URL, which caused permission requests on Mainnet to fail https://github.com/MetaMask/snap-7715-permissions/releases/tag/v10.0.0 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/37675?quickstart=1) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Fixed a bug causing advanced permissions requests on mainnet to fail before showing the permission picker ## **Related issues** Fixes: https://github.com/metamask/delegator-readable-permissions/issues/471 ## **Manual testing steps** 1. Open Gator Permissions test page 2. Select Mainnet 3. Request Permission Expect permission picker to appear ## **Screenshots/Recordings** <img width="512" height="732" alt="image" src="https://github.com/user-attachments/assets/24973492-10d6-4de8-b504-18815ebf311f" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Bumps `@metamask/gator-permissions-snap` from `^0.6.0` to `^0.6.1`, updating lockfile and attributions. > > - **Dependencies**: > - Upgrade `@metamask/gator-permissions-snap` from `^0.6.0` to `^0.6.1` in `package.json`. > - Update `yarn.lock` to resolve `@metamask/gator-permissions-snap@0.6.1`. > - **Meta**: > - Update `attribution.txt` entry for `@metamask/gator-permissions-snap` to `0.6.1`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit afe2bf6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> [fa745da](fa745da) --------- Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
1 parent 33ae905 commit 890e73b

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

attribution.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30048,7 +30048,7 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
3004830048
******************************
3004930049

3005030050
@metamask/gator-permissions-snap
30051-
0.6.0 <https://github.com/MetaMask/snap-7715-permissions>
30051+
0.6.1 <https://github.com/MetaMask/snap-7715-permissions>
3005230052
license: (MIT-0 OR Apache-2.0)
3005330053
authors: undefined
3005430054

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@
302302
"@metamask/etherscan-link": "^3.0.0",
303303
"@metamask/gas-fee-controller": "^25.0.0",
304304
"@metamask/gator-permissions-controller": "^0.4.0",
305-
"@metamask/gator-permissions-snap": "^0.6.0",
305+
"@metamask/gator-permissions-snap": "^0.6.1",
306306
"@metamask/institutional-wallet-snap": "1.3.4",
307307
"@metamask/jazzicon": "patch:@metamask/jazzicon@npm%3A2.0.0#~/.yarn/patches/@metamask-jazzicon-npm-2.0.0-36957be38d.patch",
308308
"@metamask/json-rpc-engine": "^10.0.0",

yarn.lock

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6472,17 +6472,17 @@ __metadata:
64726472
languageName: node
64736473
linkType: hard
64746474

6475-
"@metamask/gator-permissions-snap@npm:^0.6.0":
6476-
version: 0.6.0
6477-
resolution: "@metamask/gator-permissions-snap@npm:0.6.0"
6475+
"@metamask/gator-permissions-snap@npm:^0.6.1":
6476+
version: 0.6.1
6477+
resolution: "@metamask/gator-permissions-snap@npm:0.6.1"
64786478
dependencies:
64796479
"@metamask/abi-utils": "npm:3.0.0"
64806480
"@metamask/delegation-core": "npm:0.2.0"
64816481
"@metamask/profile-sync-controller": "npm:21.0.0"
64826482
"@metamask/snaps-sdk": "npm:8.1.0"
64836483
"@metamask/utils": "npm:11.4.2"
64846484
zod: "npm:3.25.76"
6485-
checksum: 10/cc28d01808f6d91566c4a7bac69961d6592f8c918e1099984e36ab5107d5123b81832ced97181134c3f0a7bf092d7006b2f3555ee0c369853a256f2ecc264a31
6485+
checksum: 10/99e93ee4237e47d98668882998dae12376a4b8ac0ba2f4e7f3164f3a4f2ad2334b0b07c14ee0e972bec3bf51ba5578a38e360fcdcc7d6ec04e9a17eb9c85ddeb
64866486
languageName: node
64876487
linkType: hard
64886488

@@ -32041,7 +32041,7 @@ __metadata:
3204132041
"@metamask/foundryup": "npm:^1.0.1"
3204232042
"@metamask/gas-fee-controller": "npm:^25.0.0"
3204332043
"@metamask/gator-permissions-controller": "npm:^0.4.0"
32044-
"@metamask/gator-permissions-snap": "npm:^0.6.0"
32044+
"@metamask/gator-permissions-snap": "npm:^0.6.1"
3204532045
"@metamask/institutional-wallet-snap": "npm:1.3.4"
3204632046
"@metamask/jazzicon": "patch:@metamask/jazzicon@npm%3A2.0.0#~/.yarn/patches/@metamask-jazzicon-npm-2.0.0-36957be38d.patch"
3204732047
"@metamask/json-rpc-engine": "npm:^10.0.0"

0 commit comments

Comments
 (0)