-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Commit b5a236e
authored
fix: cp-12.15.0 remove sentry cdn url from sentry script (#31360)
We don't use this code path, but just having this url appear in our
extension bundle makes it looks like we could load code from an external
source, something which is not permitted by extension web stores.
To test: download the build (or build it yourself), extract it, search
the source the code for `browser.sentry-cdn.com`. It should not exist.
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
## **Description**
[](https://codespaces.new/MetaMask/metamask-extension/pull/31360?quickstart=1)
## **Related issues**
Fixes:
## **Manual testing steps**
1. Go to this page...
2.
3.
## **Screenshots/Recordings**
### **Before**
### **After**
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
-->1 parent ca38751 commit b5a236eCopy full SHA for b5a236e
File tree
Expand file treeCollapse file tree
3 files changed
+250
-3
lines changedOpen diff view settings
Filter options
- .yarn/patches
Expand file treeCollapse file tree
3 files changed
+250
-3
lines changedOpen diff view settings
0 commit comments