Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't add token with a Symbol longer than 6 charachters #10973

Closed
jamiehewitt15 opened this issue May 3, 2021 · 3 comments
Closed

Can't add token with a Symbol longer than 6 charachters #10973

jamiehewitt15 opened this issue May 3, 2021 · 3 comments

Comments

@jamiehewitt15
Copy link

Describe the bug
When attempting to add a token that has a symbol length of more than 6 characters I am getting the following error message in the console:

MetaMask - RPC Error: Invalid symbol "QUICRA-0": longer than 6 characters. 

Steps to reproduce
Steps to reproduce the error:

  1. Go to https://market-git-issue-549-token-length-oceanprotocol.vercel.app/asset/did:op:7Bce67697eD2858d0683c631DdE7Af823b7eea38
  2. Click 'Connect Wallet' and select metamask
  3. Once metamask is connected, click on 'ADD QUICRA-0 TO WALLET'
  4. Open the console
  5. See error

Expected behavior
To my understanding it should be possible to add custom tokens with symbols up to 12 characters long.
This was implemented here: #5816
And appears to still be implemented here:

if (symbolLength <= 0 || symbolLength >= 12) {

Browser details (please complete the following information):

  • OS: Ubuntu
  • Browser: Firefox Browser 88.0 (64-bit)]
  • MetaMask Version 9.4.0
@jamiehewitt15
Copy link
Author

I'm also experiencing the same issue on Chrome with MetaMask Version 9.4.0

@tmashuang
Copy link
Contributor

Closed, #10670 has been merged.

@jamiehewitt15
Copy link
Author

@tmashuang I'm using Metamask 9.4.0 (which is the latest) and it's still giving me the Invalid symbol "QUICRA-0": longer than 6 characters. error. Do you know when #10670 will be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants