Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate into Brave #1301

Closed
danfinlay opened this issue Mar 31, 2017 · 12 comments
Closed

Integrate into Brave #1301

danfinlay opened this issue Mar 31, 2017 · 12 comments

Comments

@danfinlay
Copy link
Contributor

danfinlay commented Mar 31, 2017

Brave wrote a blog post on integrating extensions, it's fairly straightforward!

@danfinlay
Copy link
Contributor Author

danfinlay commented Apr 17, 2017

Blocked by lack of good extension debugging tools.

@danfinlay danfinlay added this to the Public Release milestone Apr 17, 2017
@danfinlay
Copy link
Contributor Author

Brave has added an issue just for our extension, and is tracking each API that we use that they need to implement! They even caught a deprecated API that we're calling!:

brave/browser-laptop#8671

@bneiluj
Copy link

bneiluj commented Oct 8, 2017

@danfinlay Any plan to integrate Metamask plugin into Brave extension UI for massive adoption ?

@danfinlay
Copy link
Contributor Author

@bneiluj I'm not sure what you're asking, but we're actively working with Brave, exploring what might work. Not sure that guarantees "massive adoption".

@bneiluj
Copy link

bneiluj commented Oct 9, 2017

@danfinlay A Metamask "Plug & Play" extension from Brave Extensions interface which is easier for people than cloning Brave’s browser-laptop repo and then get Metamask extension from the unique ID.

screen shot 2017-10-08 at 11 35 14

@danfinlay
Copy link
Contributor Author

@bneiluj I don't know if you saw above, but Brave is actively trying to do exactly this:

brave/browser-laptop#8671

We're waiting for them to implement all the APIs that we use.

@bneiluj
Copy link

bneiluj commented Oct 19, 2017

@danfinlay thanks a lot.
Looks like Brave has just registered MetamaskID into their components: brave/browser-laptop@3cde431

@danfinlay
Copy link
Contributor Author

This has shipped, you just have to enable experimental extensions for the moment!

@ghost
Copy link

ghost commented Oct 24, 2017

This has shipped, you just have to enable experimental extensions for the moment!

Works on my machine without enabling experimental extensions. Brave v0.19.53

@pingram3541
Copy link

It's no where to be found in the Brave extensions. How are we supposed to use MM w/ Brave again?

@danfinlay
Copy link
Contributor Author

Either under "Extensions" in the "Preferences" section, or when visiting a Dapp that requests web3, it will be suggested automatically. You may have an outdated copy of Brave?

@pingram3541
Copy link

Yep that was it. I installed via snap which I don't use very frequently and something in the sanp documentation led me to believe it updates apps automatically. Then I got an error when trying to execute: snap refresh brave and was forced to restart the snapd service.

I was v18... and now v20... and I found the newly added MetaMask capability thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants