-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate into Brave #1301
Comments
Blocked by lack of good extension debugging tools. |
Brave has added an issue just for our extension, and is tracking each API that we use that they need to implement! They even caught a deprecated API that we're calling!: |
@danfinlay Any plan to integrate Metamask plugin into Brave extension UI for massive adoption ? |
@bneiluj I'm not sure what you're asking, but we're actively working with Brave, exploring what might work. Not sure that guarantees "massive adoption". |
@danfinlay A Metamask "Plug & Play" extension from Brave Extensions interface which is easier for people than cloning Brave’s browser-laptop repo and then get Metamask extension from the unique ID. |
@bneiluj I don't know if you saw above, but Brave is actively trying to do exactly this: We're waiting for them to implement all the APIs that we use. |
@danfinlay thanks a lot. |
This has shipped, you just have to enable experimental extensions for the moment! |
Works on my machine without enabling experimental extensions. Brave v0.19.53 |
It's no where to be found in the Brave extensions. How are we supposed to use MM w/ Brave again? |
Either under "Extensions" in the "Preferences" section, or when visiting a Dapp that requests web3, it will be suggested automatically. You may have an outdated copy of Brave? |
Yep that was it. I installed via snap which I don't use very frequently and something in the sanp documentation led me to believe it updates apps automatically. Then I got an error when trying to execute: I was v18... and now v20... and I found the newly added MetaMask capability thank you! |
Brave wrote a blog post on integrating extensions, it's fairly straightforward!
The text was updated successfully, but these errors were encountered: