Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work with Keystone folks to enable TypeScript strict mode on @keystonehq/ur-registry #13536

Open
mcmire opened this issue Feb 7, 2022 · 1 comment

Comments

@mcmire
Copy link
Contributor

mcmire commented Feb 7, 2022

In adding support for TypeScript to the codebase, we plan on enabling strict mode, which is a setting in tsconfig.json that the TypeScript team recommends which enables a bunch of other settings designed to promote higher code quality/design and catch more runtime errors.

The problem here is that if we enable strict mode, all of the packages we use that are written in TypeScript also have to have been developed with strict mode as well. This seems to be the case for the packages we use so far but for one: Keystone's ur-registry package. There is an issue open in the repo for this package to track enabling of strict mode, but this may involve fixing some issues in the codebase itself. We need to work with the Keystone team to do this in a way that doesn't break backward compatibility.

@mcmire mcmire self-assigned this Feb 7, 2022
@mcmire mcmire removed their assignment Dec 5, 2022
@mcmire
Copy link
Contributor Author

mcmire commented Dec 5, 2022

Taking myself off of this as I don't have time for this unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants