-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle FILE_ERROR_NO_SPACE
error gracefully
#14525
Comments
Is there someway we could know this? Other than just seeing when the error stops happening? If not, it seems to me we should just make it dismissible and then pop it up again each time we get this error. @Gudahtt cc @rachelcope |
We try to persist state every time it changes, with a 1 second debounce. Effectively the dismiss button would appear to have not worked if we took that approach. |
@Gudahtt so then could we dismiss it when a successful state persistence occurs? |
Alright @rachelcope so a slightly updated understanding of our options here:
With 1 the risk is that users dismiss it thoughtlessly and then don't understand why the app isn't working as expected. cc @Gudahtt |
ping here @rachelcope |
Friendly ping here @rachelcope |
We currently see many instances of the error
FILE_ERROR_NO_SPACE
in Sentry. These errors occur when a user runs out of disk space and state persistence of app related state fails.Currently these errors are not surfaced to the user meaning that we will not persist state which may result in unexpected or buggy behavior in the extension and fail to warn the user as to why they may be experiencing buggy behavior.
We should intercept these errors and show the user a legible error message that will either help them resolve the issue by freeing up space or at least clear up confusion about why the extension is failing to behave as expected.
We should also move the logging of these errors from sentry to segment.
For Design:
The lifecycle of this error notice needs a spec
The text was updated successfully, but these errors were encountered: