Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle FILE_ERROR_NO_SPACE error gracefully #14525

Open
2 tasks
adonesky1 opened this issue Apr 25, 2022 · 7 comments
Open
2 tasks

Handle FILE_ERROR_NO_SPACE error gracefully #14525

adonesky1 opened this issue Apr 25, 2022 · 7 comments
Assignees
Labels
area-Sentry error reporting to sentry area-storage

Comments

@adonesky1
Copy link
Contributor

adonesky1 commented Apr 25, 2022

We currently see many instances of the error FILE_ERROR_NO_SPACE in Sentry. These errors occur when a user runs out of disk space and state persistence of app related state fails.

Currently these errors are not surfaced to the user meaning that we will not persist state which may result in unexpected or buggy behavior in the extension and fail to warn the user as to why they may be experiencing buggy behavior.

  • We should intercept these errors and show the user a legible error message that will either help them resolve the issue by freeing up space or at least clear up confusion about why the extension is failing to behave as expected.

  • We should also move the logging of these errors from sentry to segment.

For Design:

The lifecycle of this error notice needs a spec

  • Should we allow this to be dismissed? Or should we show this until the user does clear space?
  • If we allow it to be dismissed, do we leave it dismissed forever? What if the user clears space, then it fills up again?
@adonesky1 adonesky1 added area-Sentry error reporting to sentry area-storage labels Apr 25, 2022
@adonesky1
Copy link
Contributor Author

A WIP commit from @Gudahtt with related work: f00fe87

@adonesky1 adonesky1 assigned rachelcope and unassigned Gudahtt Apr 25, 2022
@adonesky1
Copy link
Contributor Author

adonesky1 commented Apr 25, 2022

Or should we show this until the user does clear space?

Is there someway we could know this? Other than just seeing when the error stops happening? If not, it seems to me we should just make it dismissible and then pop it up again each time we get this error. @Gudahtt

cc @rachelcope

@Gudahtt
Copy link
Member

Gudahtt commented Apr 25, 2022

We try to persist state every time it changes, with a 1 second debounce. Effectively the dismiss button would appear to have not worked if we took that approach.

@adonesky1
Copy link
Contributor Author

@Gudahtt so then could we dismiss it when a successful state persistence occurs?

@adonesky1
Copy link
Contributor Author

adonesky1 commented Apr 26, 2022

Alright @rachelcope so a slightly updated understanding of our options here:
Our best options as I understand them are:

  1. Make this alert dismissible and not show it again until we see that the issue has been fixed and then subsequently reoccurs.
  2. Not make it dismissible by the user but dismiss it ourselves when we detect that the issue has been resolved

With 1 the risk is that users dismiss it thoughtlessly and then don't understand why the app isn't working as expected.
With 2 the risk is that users are frustrated with an un-dismissible alert.

cc @Gudahtt

@adonesky1
Copy link
Contributor Author

ping here @rachelcope

@adonesky1
Copy link
Contributor Author

Friendly ping here @rachelcope ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Sentry error reporting to sentry area-storage
Projects
None yet
Development

No branches or pull requests

4 participants