Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet Tx Security Provider: Send the transaction or signature request payload information to a service provider #16281

Closed
dragana8 opened this issue Oct 26, 2022 · 3 comments · Fixed by #16584
Assignees
Labels
area-transactions PS-team PS MM extension team issues team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-enhancement

Comments

@dragana8
Copy link
Contributor

User story

As a user, I want my unsigned transaction and signatures requests to be sent to my security provider so it can verify whether it’s malicious or not before I sign them. Any eth_sendTransaction, eth_sign, personal_sign, or signTypedData_vXX method request would be forwarded to SECURITY_PROVIDER_RPC_URL in the standard JSON RPC request format prior to rendering a transaction confirmation modal to the user.

Tasks:

  1. Check wether tx security provider is turned on;
  2. If yes, unsigned transaction or signature request payload (eth_rpc call + url) is sent to tx security provider;
  3. Tx security provider sends back a boolean response wether it wants to flag it as malicious or not
@bschorchit bschorchit added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Oct 26, 2022
@filipsekulic filipsekulic self-assigned this Oct 28, 2022
@bschorchit
Copy link

More details on data format to be forwarded available here

@bschorchit
Copy link

We should include language in ISO 639-2 code in the data we share. Slack thread cc: @filipsekulic

@sambacha
Copy link

Metamask does not allow progmatic change of chainId wrt Mainnet Ethereum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-transactions PS-team PS MM extension team issues team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants