Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't show currency conversions for Sepolia testnet #17054

Open
adonesky1 opened this issue Dec 22, 2022 · 1 comment
Open

We don't show currency conversions for Sepolia testnet #17054

adonesky1 opened this issue Dec 22, 2022 · 1 comment
Assignees
Labels
team-assets team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead

Comments

@adonesky1
Copy link
Contributor

Even with Show conversion on test networks setting turned on we don't show conversions. I vaguely remember that we hardcoded something for getting conversions for testnet eth somewhere

@adonesky1 adonesky1 self-assigned this Dec 22, 2022
@emedvedev
Copy link

emedvedev commented Jan 6, 2023

This should be fixed when MetaMask/core#1041 is merged in, from what I can tell. You'd need to add SepoliaETH to TESTNET_TICKER_SYMBOLS so that the conversion rate would fall back to ETH, and 1041 includes that change.

Tried to fix the bug myself and saw that there's a solution already. :)

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 20, 2023
@pedronfigueiredo pedronfigueiredo removed the stale issues and PRs marked as stale label Jul 20, 2023
@MetaMask MetaMask deleted a comment from github-actions bot Jul 20, 2023
@gauthierpetetin gauthierpetetin added team-assets team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead and removed team-extension-client labels Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-assets team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

No branches or pull requests

5 participants