Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract confirm-transaction-base.component.js functions renderData, renderDataHex into separate components #17419

Closed
jpuri opened this issue Jan 25, 2023 · 0 comments · Fixed by #17822
Closed

Extract confirm-transaction-base.component.js functions renderData, renderDataHex into separate components #17419

jpuri opened this issue Jan 25, 2023 · 0 comments · Fixed by #17822
Assignees
@jpuri
Labels
team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor

Comments

@jpuri
Copy link
Contributor

jpuri commented Jan 25, 2023 •
edited
Loading

Extract confirm-transaction-base.component.js functions renderData, renderDataHex can be extracted out into separate components

  1. renderData
  2. renderDataHex

Create simple functional component that use selectors to query state. Minimise props passing.

2 separate PRs can be created for each function. Ensure text coverage of new components created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpuri jpuri

Labels
team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-refactor
Projects
None yet
Milestone
No milestone
1 participant
@jpuri