Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Task] Implement info subsection for advanced view in contract interaction #23946

Closed
pedronfigueiredo opened this issue Apr 10, 2024 · 1 comment · Fixed by #24833
Closed
Assignees
Labels
confirmation-re-design confirmation-redesign INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. needs-decision Needs a decision from MetaMask in order to proceed. needs-estimate release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Comments

@pedronfigueiredo
Copy link
Contributor

pedronfigueiredo commented Apr 10, 2024

Important

Question for @bschorchit: When the user toggles the advanced nonce controls setting we:
a) Make the nonce visible or
b) Make the nonce editable (and it's always visible)

Important

@SayaGT to supply tooltip wireframes and copy

Important

@SayaGT to supply wireframes for nonce edit behavior and validation. What happens if the user inputs -1?

Progresses #23905

Context

Toggle:

Screenshot 2024-04-11 at 12 35 36

SubSection:

Screenshot 2024-04-11 at 12 34 56

(source: Figma design file)

Approach

The section appears after clicking the icon in the header

Create a dedicated component inside the confirm/info folder. The component will be imported inside the contract-interaction info component.

This component will include the ability to edit the nonce. We can reuse this action:

https://github.com/MetaMask/metamask-extension/blob/develop/ui/store/actions.ts#L762-L767

Acceptance Criteria

  • Implement a new component that includes the described functionality.
  • Use that component in the info section for contract interaction.
  • Add the icon to the header.
  • Create a hook at the info component level to expand and collapse the section. Pass down the setter to the header component and the value to the info component and into this subsection of the contract interaction component.
@pedronfigueiredo pedronfigueiredo added the team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead label Apr 10, 2024
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Apr 10, 2024
@pedronfigueiredo pedronfigueiredo added needs-decision Needs a decision from MetaMask in order to proceed. team-confirmations-planning (only for internal use within Confirmations team) confirmation-redesign confirmation-re-design needs-estimate needs-design Needs design support. labels Apr 11, 2024
@pedronfigueiredo pedronfigueiredo changed the title [Tech Task] Implement advanced view subsection in contract interaction info [Tech Task] Implement info subsection for advanced view in contract interaction Apr 11, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
@bschorchit
Copy link

Important

Question for @bschorchit: When the user toggles the advanced nonce controls setting we:
a) Make the nonce visible or
b) Make the nonce editable (and it's always visible)

a). When the user toggles the advanced nonce controls setting we make the nonce visible and editable. If the toggle is off, the nonce should not visible.

@pedronfigueiredo pedronfigueiredo self-assigned this May 24, 2024
@bschorchit bschorchit removed team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead team-confirmations-planning (only for internal use within Confirmations team) labels May 29, 2024
@github-actions github-actions bot removed the needs-design Needs design support. label Jun 21, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmation-re-design confirmation-redesign INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. needs-decision Needs a decision from MetaMask in order to proceed. needs-estimate release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants