Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move formatDate from ui/helpers/utils/util.js to shared, and standardize its usage #24554

Open
danjm opened this issue May 16, 2024 · 0 comments
Open

move formatDate from ui/helpers/utils/util.js to shared, and standardize its usage #24554

danjm opened this issue May 16, 2024 · 0 comments
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-extension-platform

Comments

@danjm
Copy link
Contributor

danjm commented May 16, 2024

We have a formatDate method in ui/helpers/utils/util.js. We also have one in shared/notifications/index.ts. As of #24503, we also have one in app/scripts/controllers/metametrics-data-deletion/metametrics-data-deletion.ts

We should create one standard formatDate method that is used throughout the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. team-extension-platform
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danjm @metamaskbot