Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: when sending a batchRequest the same nonce for all transactions #28239

Closed
Pasha8914 opened this issue Nov 1, 2024 · 6 comments
Closed

[Bug]: when sending a batchRequest the same nonce for all transactions #28239

Pasha8914 opened this issue Nov 1, 2024 · 6 comments
Labels
external-contributor regression-prod-12.5.0 Regression bug that was found in production in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug

Comments

@Pasha8914
Copy link

Describe the bug

When sending a Batch request, confirmation windows appear with the same nonce

Expected behavior

nonce should be different

Screenshots/Recordings

Screen.Recording.2024-11-01.at.22.02.34.mov

Steps to reproduce

  1. Run project
  2. Click Send self-tx
  3. Sign your first transaction instantly
  4. Second transaction has same nonce

Error messages or log output

No response

Detection stage

In production (default)

Version

12.5.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

High probability of losing funds
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Nov 1, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Nov 1, 2024
@metamaskbot metamaskbot added external-contributor regression-prod-12.5.0 Regression bug that was found in production in release 12.5.0 labels Nov 1, 2024
@dan1kov
Copy link

dan1kov commented Nov 1, 2024

I have the same problem ☹️

@lamarinatesh
Copy link

☝️☝️

@seaona
Copy link
Contributor

seaona commented Nov 4, 2024

Might be similar/same as #27617

@seaona seaona mentioned this issue Nov 4, 2024
Closed
@seaona seaona added Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team labels Nov 4, 2024
@bschorchit
Copy link

This will be fixed on extension release v12.7 if the user has "Improve transaction requests" toggle enabled. The toggle will be automatically enabled to all users on v12.8

@sleepytanya sleepytanya mentioned this issue Nov 6, 2024
Merged
7 tasks
@sleepytanya
Copy link
Contributor

Possibly fixed by #28272

@bschorchit
Copy link

Closing as this has been fixed

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 4, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
external-contributor regression-prod-12.5.0 Regression bug that was found in production in release 12.5.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-confirmations Push issues to confirmations team type-bug
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@dan1kov @bschorchit @metamaskbot @Pasha8914 @seaona @lamarinatesh @sleepytanya