[Bug]: Token Conversion - API request to cryptocompare is made with the token ticker name resulting in a non-real balance conversion #28262
Labels
regression-RC-12.7.0
Sev2-normal
Normal severity; minor loss of service or inconvenience.
team-assets
type-bug
Describe the bug
Whenever I change the default ticker to a different one, I see how the API request to cryptocompare is made with the new ticker name as a payload. This results in getting a non real conversion of my current assets in that network.
Ie.
$135,706.33
converted in fiat.Now I change the token name to BTC and I can see how a request to cryptocompare is made with the BTC token payload.
The result is that now I see in my wallet a total of
$3,780,853.33
Expected behavior
I'm not sure we should base the cryptocompare request on the name of the token.
Maybe we shouldn't display the conversion for such cases, as the network doesn't have the expected token name? This is what's currently happening in prod: we don't display the conversion but rather the token, with whichever name we set.
Screenshots/Recordings
currency-change-ticker.mp4
Steps to reproduce
Error messages or log output
No response
Detection stage
During release testing
Version
12.7.0
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: