Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Override chain id in network config #3453

Closed
kumavis opened this issue Mar 6, 2018 · 7 comments
Closed

Feature: Override chain id in network config #3453

kumavis opened this issue Mar 6, 2018 · 7 comments
Labels
area-background Issues relating to the extension background process. type-enhancement

Comments

@kumavis
Copy link
Member

kumavis commented Mar 6, 2018

Currently we use the rpc response of net_version for the EIP155 chainId value when signing all txs.

For some chains (e.g. ETC) net_version !== chainId which causes an invalid tx sig for the network.

The correct thing to do is introduce an rpc method for querying the chainId.

A workaround is to allow the user to override the chainId in the network settings.

This feature includes:

  • UI to set the chainId
  • wiring to use this chainId in the tx signing process
@kumavis kumavis added P4-someday area-background Issues relating to the extension background process. type-enhancement labels Mar 6, 2018
@kumavis
Copy link
Member Author

kumavis commented Mar 6, 2018

If you want this feature, please let us know what network you are wanting to use

@p-s-dev
Copy link

p-s-dev commented Mar 11, 2018

The VictoriumProject uses "network": 93610431 and (eip155) "chainID": 4388577777

https://github.com/VictoriumProject/go-victorium/blob/master/core/config/mainnet.json

@Legacytrx
Copy link

Hi, any progress on this as we have the same problem with Atheios:
Network ID: 11235813
Chain ID: 1620
?

@hackmod
Copy link
Contributor

hackmod commented Aug 23, 2018

See also PR #4932

@buhrmi
Copy link

buhrmi commented Aug 28, 2018

Hi guys, any update on this? I want to use the "old" ethereum network with chainid 61 because i dont like the main net.

@buhrmi
Copy link

buhrmi commented Aug 28, 2018

#5134 seems to do exactly what I need... Can I do something to help getting it merged?

@Gudahtt
Copy link
Member

Gudahtt commented Jan 6, 2021

We now require the chain_id to be specified on all custom networks, and we call eth_chainId to verify that it matches the network chain id. I think this satisfies the original problem here well enough.

@Gudahtt Gudahtt closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-background Issues relating to the extension background process. type-enhancement
Projects
None yet
Development

No branches or pull requests

6 participants