Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading ENS pages (.eth) overwrites DNS results and doesn't work on Firefox #5009

Closed
eduadiez opened this issue Aug 9, 2018 · 0 comments · Fixed by #5010
Closed

Loading ENS pages (.eth) overwrites DNS results and doesn't work on Firefox #5009

eduadiez opened this issue Aug 9, 2018 · 0 comments · Fixed by #5010

Comments

@eduadiez
Copy link
Contributor

eduadiez commented Aug 9, 2018

The functionality introduced in v4.9.0 to resolve .eth domains doesn't check if the user's DNS is able to resolve a .eth or .test address. Therefore the extension prevents the user to access these sites even though the DNS is returning an IP address.

Also, the current implementation doesn't work in Firefox (tested on version 61.0.1) as it relies on a deprecated method: tabs.getSelected mozilla.org reference

  • Expected Behavior

Don't overwrite domains that exist or if the DNS is able to resolve and work in both browsers in the same way

  • Actual Behavior

It doesn't work in Firefox, it overwrites domains that end in .eth and .test

  • Browser Used

Firefox & Chrome

  • Operating System Used

MacOS High Sierra

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant