Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model T not working with web3.eth.sign() #5021

Closed
dconroy opened this issue Aug 9, 2018 · 1 comment
Closed

Model T not working with web3.eth.sign() #5021

dconroy opened this issue Aug 9, 2018 · 1 comment

Comments

@dconroy
Copy link

dconroy commented Aug 9, 2018

Describe the bug
When using hardware wallet, Model T Trezor, I am able to send /receive ether as expected. However, when using a dApp that requires web3.eth.sign(), after clicking the sign transaction button in meta mask, there is never any subsequent popups in chrome or any confirmation prompted on the hardware device.

To Reproduce
Steps to reproduce the behavior:

  1. Plug in Model T
  2. Unlock with pin
  3. Use dapp that requires web3.eth.sign()
  4. Sign message in meta mask
  5. Expect a chrome popup or confirmation on device, but never happens

Expected behavior
I would expect to confirm this signature action on my device.

Browser details (please complete the following information):

  • MacOS High Sierra, 10.13.6:
  • Chrome Version 68.0.3440.106 (Official Build) (64-bit)
  • MetaMask Version 4.9.0
  • New UI
@brunobar79
Copy link
Contributor

brunobar79 commented Aug 9, 2018

Hi @dconroy, you are right about that method not working with TREZOR via metamask.
The main reason is that the TREZOR connect API only supports one signing method (See https://github.com/trezor/connect/blob/develop/docs/methods.md#ethereum), which uses personalSign under the hood and this is what most dApps use (for ex. CryptoKitties).

I don't think TREZOR will be adding support for it since it has been deprecated. You can read more about it at the beginning of this article or here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants