Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipfsContent.js prevents connecting to all websites under certain conditions #5460

Closed
eduadiez opened this issue Oct 8, 2018 · 1 comment
Closed

Comments

@eduadiez
Copy link
Contributor

eduadiez commented Oct 8, 2018

Describe the bug
With the current implementation of ipfsContent.js all requests are listened even of the type xmlhttprequest, websockets, ...

I think the current implementation is too invasive, and it may turn out that if you use a .eth as a metamask provider and the connection is lost you won't be able to access to any website (neither .eth nor any other TLD)

Example:

21:36:17.461 console.js:35 {error: "net::ERR_NAME_NOT_RESOLVED", frameId: 0, fromCache: false, initiator: "http://mycrypto.dappnode.eth", method: "OPTIONS", …}error: "net::ERR_NAME_NOT_RESOLVED"frameId: 0fromCache: falseinitiator: "http://mycrypto.dappnode.eth"method: "OPTIONS"parentFrameId: -1requestId: "7600"tabId: 1345496486timeStamp: 1539027377460.8418type: "xmlhttprequest"url: "http://my.ethchain.dnp.dappnode.eth:8545/"__proto__: Object

Although this commit can partially fix the problem, it only solves it in case of using a port in the url

I think it should use webRequest.RequestFilter to filter only main_frame the request.

@eduadiez
Copy link
Contributor Author

eduadiez commented Oct 8, 2018

I just made a PR to fix this problem #5461

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant