Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollable home page & inline transaction detail view #5508

Closed
bdresser opened this issue Oct 11, 2018 · 2 comments
Closed

Scrollable home page & inline transaction detail view #5508

bdresser opened this issue Oct 11, 2018 · 2 comments
Assignees
Labels
area-UI Relating to the user interface.

Comments

@bdresser
Copy link
Contributor

We've introduced several different floating or sliding elements in to the extension, most added individually, and the modal transaction detail view & slide-in "speed up" component make for a very awkward transition. This issue aims to simplify UI treatment of a couple new elements:

We should

  • make it so that everything from the account nickname and below scrolls together. That includes transaction history, overall ETH balance, overall fiat balance, deposit/send buttons, and token/ETH logo. The bar with hamburger menu, account bar, and account ... options should be fixed.
  • show the transaction detail view inline (as it's shown in the full-tab view).
  • remove that tiny line on top of the transaction history because we don't need it and it will make @cjeria very happy 😄

screen shot 2018-10-11 at 1 30 11 pm

@bdresser bdresser added the area-UI Relating to the user interface. label Oct 11, 2018
@alextsg
Copy link
Contributor

alextsg commented Oct 16, 2018

@bdresser Just to confirm, bullet point 2 is referring to removing the flow of opening up a modal with the transaction details and using the expanding behavior of the full-screen view right?

@bdresser
Copy link
Contributor Author

@alextsg correct - like it used to be in your first iteration 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface.
Projects
None yet
Development

No branches or pull requests

2 participants