MetaMask firefox is swallowing error messages.

[MicahZoltu]

Describe the bug
When looking at the console log output in Firefox, all I get is:

RPC Error: Internal JSON-RPC error. 
Object { code: -32603, message: "Internal JSON-RPC error." }

and if I look at the error response my dapp received I get:

{
  "id": 42,
  "jsonrpc": "2.0",
  "error": {
    "code": -32603,
    "message": "Internal JSON-RPC error."
  }
}

However, if I look in the Firefox AddOn debugger I can see that the actual error was:

{"jsonrpc":"2.0","error":{"code":-32015,"message":"Transaction execution error.","data":"Internal(\"Requires higher than upper limit of 76784210\")"},"id":3305582744}

To Reproduce
Steps to reproduce the behavior:

1. Open a browser with MetaMask enabled and approved for the page.
2. in the console do ethereum.sendAsync({...}, console.log, console.log) filled in with a transaction that will fail.
3. Notice that you get crappy errors in the console.
4. Notice that in the Firefox AddOn debugger you get good error messages.

Expected behavior
Error message from remote node propagated to user.

Browser details (please complete the following information):

• OS: Windows 10
• Browser: Firefox
• MetaMask Version: 5.1.0

[smithki]

Possibly related: Firefox and/or MetaMask is garbling error messages with an impossible-to-read stack trace:

MetaMask - RPC Error: value/</<@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:144859
h@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:750837
[262]</a.prototype.emit/<@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:752631
[262]</a.prototype.emit@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:752701
value@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:147818
value@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:147416
value@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:177831
[475]</c.prototype.apply@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:941322
[475]</c.prototype.handle@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:941024
[481]</</a.prototype.handle@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:944694
[481]</</a.prototype.write@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:944599
m@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1953394
[262]</a.prototype.emit/<@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:752631
[262]</a.prototype.emit@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:752701
_@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1948233
w@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1948048
[867]</</v.prototype.push@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1948859
_write@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1907743
v@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1961008
[869]</</g.prototype.write/a<@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1964120
[869]</</g.prototype.write@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1964147
m@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1330346
[262]</a.prototype.emit/<@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:752631
[262]</a.prototype.emit@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:752701
_@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1325149
w@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1324964
[614]</</v.prototype.push@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1325775
[610]</</o.prototype._onMessage@moz-extension://2de7e800-9f9b-d541-a858-676d51566b24/background.js:1:1319725

versus Chrome:

MetaMask - RPC Error: Error: MetaMask Message Signature: User denied message signature.

[wbt]

Chrome is not necessarily better...MetaMask seems to be swallowing messages in multiple places! (Other example here)

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[wbt]

After the closure of #8975 & #12646, I don't think this should be closed without an improvement.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[wbt]

I still don't think this should be closed without an improvement.

[gauthierpetetin]

Related issue: #20315

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.