Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web3.eth.defaultAccount still being exposed without enable #6105

Closed
aakilfernandes opened this issue Feb 3, 2019 · 2 comments
Closed

web3.eth.defaultAccount still being exposed without enable #6105

aakilfernandes opened this issue Feb 3, 2019 · 2 comments

Comments

@aakilfernandes
Copy link

I'm on Metamask 5.3.4, and account addresses are still being injected into every page.

I was under the impression this was fixed in 4.14

screen shot 2019-02-03 at 3 36 36 pm

@aakilfernandes
Copy link
Author

I figured out I have to enable privacy mode, cmon guys, this is not acceptable. It's been almost two years. Please fix this.

https://incoherency.co.uk/blog/stories/metamask-identification.html

@danfinlay
Copy link
Contributor

We were planning to make this a breaking change, but since we designed our rollout process, we found a revised approach (#6110) that will allow implementing this feature without breaking previous sites, which we consider an important virtue of the web.

You're that we hadn't been actively developing it, but we have been working on some strong improvements to privacy and security long term, so please understand we are constantly working towards a strong platform long-term.

@MetaMask MetaMask locked as too heated and limited conversation to collaborators Feb 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants