Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow manual enable for legacy sites. #6320

Closed
MicahZoltu opened this issue Mar 19, 2019 · 2 comments · Fixed by #6904
Closed

Allow manual enable for legacy sites. #6320

MicahZoltu opened this issue Mar 19, 2019 · 2 comments · Fixed by #6904

Comments

@MicahZoltu
Copy link

What problem are you trying to solve?
There are a number of older sites that do not call .enable(), they just try to access web3.currentProvider. Without taking MetaMask out of privacy mode, I would like a way to be able to approve the site so it gets an injected web3.currentProvider so I can continue using the dapp.

Describe the solution you'd like
Put a button in the extension UI for "Allow this site to see your MetaMask address" (wording could probably be improved).

Additional context
Part of the idea with dapps is that they can be deployed to things like IPFS and live forever, even after the author is gone. Also, if you audit a dapp you may not want to spend (or have the) time to re-audit it so you choose to not update to a newer version of the dapp that supports .enable(). In these cases, there is value in allowing MetaMask to be backward compatible for as long as possible.

Toggling off Privacy Mode is not what I want because that disables privacy mode for every open tab I have. I want to just allow a specific site access through the UI.

@bdresser
Copy link
Contributor

This is also a relevant feature for when we enable privacy mode by default

@bdresser
Copy link
Contributor

bdresser commented Jun 5, 2019

Designs here

cc @whymarrh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants