fix(card): cp-7.58.3 physical address consent issue + undefined balances (#22676)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR hardens several Card flows:

- Mailing-address consent now recreates or reuses onboarding consent
defensively, mirroring the logic in the physical-address step.
- useWrapWithCache, CardHome, and their test suites now treat cache
errors and expired-card tokens consistently; the home screen shows a
dedicated spinner while auth cleanup runs and only processes each auth
error once.
- Onboarding/Complete now calls
navigation.dispatch(StackActions.replace(...)) (with updated tests) so
we don’t stack duplicate routes after successful onboarding.
- Card login path surfaces the new ACCOUNT_DISABLED error type with the
correct localized messaging.
- These fixes resolve missing-consent crashes, inconsistent
priority-token balances, brittle token-expiration UX, and the lingering
navigation issue after onboarding.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Improved MetaMask Card onboarding and home flows
(defensive consent creation, consistent balance caching, robust
expired-token handling, and navigation fixes).

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Defensively manage consent across onboarding, improve auth-error
cleanup and navigation, refine balance fiat/caching logic, and add
ACCOUNT_DISABLED handling with new consent lookup API.
> 
> - **Onboarding**:
> - **Mailing/Physical Address**: Add defensive consent flow
(reuse/create via `getOnboardingConsentSetByOnboardingId`, link user,
clear `consentSetId`); maintain validations and success paths.
Navigation uses replace where appropriate.
> - **Complete screen**: Switch to
`navigation.dispatch(StackActions.replace(...))` and reset onboarding
state before redirect.
> - **Card Home**:
> - Add robust auth-error handling (single-run cleanup, token removal,
Redux reset/cache clear, `StackActions.replace` to welcome, loading
spinner during cleanup) and initial authenticated data load.
> - Preserve/compute balances and spending limit UI as before; minor UX
tweaks.
> - **Hooks**:
> - `useAssetBalances`: Rework fiat formatting and fallbacks (handle
`tokenRateUndefined`/loading strings, raw fiat parsing, proportional
fiat, currency detection), keep Solana/EVM paths; expose consistent map.
> - `useWrapWithCache`: Return real `Error`, avoid auto-retries on
error, prevent refetch while loading, skip caching null/undefined; same
API.
> - `useCardDetails`: Surface `error` object (not enum), keep polling,
warnings.
> - `useGetCardExternalWalletDetails`: Guard auto-fetch on error;
unchanged API.
> - `useGetDelegationSettings`/`useRegistrationSettings`: Align to
`Error` semantics.
> - **SDK/Types**:
> - `CardSDK.login`: detect and surface `ACCOUNT_DISABLED` error; OTP
flows unchanged.
> - Add `getConsentSetByOnboardingId` endpoint support; new
`ConsentSet`/`GetOnboardingConsentResponse` types.
> - **Tests**: Extensive updates/new cases across components and hooks
to cover consent recovery, navigation replace, auth cleanup order,
cache/error behavior, and fiat formatting.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
9e3b88d. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Author: Brunonascdev

app/components/UI/Card/Views/CardHome/CardHome.test.tsx

@@ -7,6 +7,7 @@ import React, {
   useState,
 } from 'react';
 import {
+  ActivityIndicator,
   Alert,
   RefreshControl,
   ScrollView,
@@ -22,7 +23,7 @@ import Icon, {
 import Text, {
   TextVariant,
 } from '../../../../../component-library/components/Texts/Text';
-import { useNavigation } from '@react-navigation/native';
+import { StackActions, useNavigation } from '@react-navigation/native';
 import { useDispatch, useSelector } from 'react-redux';
 import SensitiveText, {
   SensitiveTextLength,
@@ -58,11 +59,8 @@ import {
 import { useCardSDK } from '../../sdk';
 import Routes from '../../../../../constants/navigation/Routes';
 import {
-  setIsAuthenticatedCard,
-  setAuthenticatedPriorityToken,
-  setAuthenticatedPriorityTokenLastFetched,
-  setUserCardLocation,
   clearAllCache,
+  resetAuthenticatedData,
 } from '../../../../../core/redux/slices/card';
 import { useCardProvision } from '../../hooks/useCardProvision';
 import CardWarningBox from '../../components/CardWarningBox/CardWarningBox';
@@ -97,8 +95,13 @@ const CardHome = () => {
   const { PreferencesController } = Engine.context;
   const [retries, setRetries] = useState(0);
   const [isRefreshing, setIsRefreshing] = useState(false);
+  const [isHandlingAuthError, setIsHandlingAuthError] = useState(false);
   const { toastRef } = useContext(ToastContext);
   const { logoutFromProvider, isLoading: isSDKLoading } = useCardSDK();
+  const hasTrackedCardHomeView = useRef(false);
+  const hasLoadedCardHomeView = useRef(false);
+  const hasHandledAuthErrorRef = useRef(false);
+  const isComponentUnmountedRef = useRef(false);
   const [
     isCloseSpendingLimitWarningShown,
     setIsCloseSpendingLimitWarningShown,
@@ -190,9 +193,6 @@ const CardHome = () => {
     }
   }, [fetchAllData]);
 
-  // Track event only once after priorityToken and balances are loaded
-  const hasTrackedCardHomeView = useRef(false);
-
   useEffect(() => {
     // Early return if already tracked to prevent any possibility of duplicate tracking
     if (hasTrackedCardHomeView.current) {
@@ -497,36 +497,75 @@ const CardHome = () => {
     styles,
   ]);
 
+  useEffect(
+    () => () => {
+      isComponentUnmountedRef.current = true;
+    },
+    [],
+  );
+
   // Handle authentication errors (expired token, invalid credentials, etc.)
   useEffect(() => {
     const handleAuthenticationError = async () => {
-      if (!cardError) {
+      const isAuthError =
+        Boolean(cardError) &&
+        isAuthenticated &&
+        isAuthenticationError(cardError);
+
+      if (!isAuthError) {
+        hasHandledAuthErrorRef.current = false;
         return;
       }
 
-      // Check if the error is authentication-related
-      if (isAuthenticated && isAuthenticationError(cardError)) {
-        Logger.log(
-          'CardHome: Authentication error detected, clearing auth state and redirecting',
-        );
+      if (hasHandledAuthErrorRef.current) {
+        return;
+      }
+
+      hasHandledAuthErrorRef.current = true;
+      setIsHandlingAuthError(true);
+
+      Logger.log(
+        'CardHome: Authentication error detected, clearing auth state and redirecting',
+      );
 
-        // Clear authentication state
+      try {
         await removeCardBaanxToken();
-        dispatch(setIsAuthenticatedCard(false));
-        dispatch(setAuthenticatedPriorityToken(null));
-        dispatch(setAuthenticatedPriorityTokenLastFetched(null));
-        dispatch(setUserCardLocation(null));
 
-        // Clear all cached data
+        if (isComponentUnmountedRef.current) {
+          return;
+        }
+
+        dispatch(resetAuthenticatedData());
         dispatch(clearAllCache());
 
-        // Redirect to welcome screen for re-authentication
-        navigation.navigate(Routes.CARD.WELCOME);
+        navigation.dispatch(StackActions.replace(Routes.CARD.WELCOME));
+      } catch (error) {
+        Logger.log('CardHome: Failed to handle authentication error', error);
+
+        if (!isComponentUnmountedRef.current) {
+          navigation.dispatch(StackActions.replace(Routes.CARD.WELCOME));
+        }
+      } finally {
+        if (!isComponentUnmountedRef.current) {
+          setIsHandlingAuthError(false);
+        }
       }
     };
 
     handleAuthenticationError();
-  }, [cardError, isAuthenticated, dispatch, navigation]);
+  }, [cardError, dispatch, isAuthenticated, navigation]);
+
+  // Load Card Data once CardHome opens
+  useEffect(() => {
+    const loadCardData = async () => {
+      await fetchAllData();
+      hasLoadedCardHomeView.current = true;
+    };
+
+    if (!hasLoadedCardHomeView.current && isAuthenticated) {
+      loadCardData();
+    }
+  }, [fetchAllData, isAuthenticated]);
 
   /**
    * Check if the current token supports the spending limit progress bar feature.
@@ -565,6 +604,16 @@ const CardHome = () => {
   }, [isAuthenticated, isSpendingLimitSupported, priorityToken]);
 
   if (cardError) {
+    const isAuthError = isAuthenticated && isAuthenticationError(cardError);
+
+    if (isHandlingAuthError || isAuthError) {
+      return (
+        <View style={styles.loadingContainer}>
+          <ActivityIndicator size="large" />
+        </View>
+      );
+    }
+
     return (
       <View style={styles.errorContainer}>
         <Icon

app/components/UI/Card/Views/CardHome/CardHome.tsx

@@ -1,12 +1,25 @@
 import React from 'react';
 import { render, fireEvent, waitFor } from '@testing-library/react-native';
-import { useNavigation } from '@react-navigation/native';
+import { StackActions, useNavigation } from '@react-navigation/native';
 import { useDispatch } from 'react-redux';
 import Complete from './Complete';
+import Routes from '../../../../../constants/navigation/Routes';
 
 // Mock dependencies
+const mockNavigationDispatch = jest.fn();
+const mockStackReplace = jest.fn((routeName: string) => ({
+  type: 'REPLACE',
+  routeName,
+}));
+
 jest.mock('@react-navigation/native', () => ({
   useNavigation: jest.fn(),
+  StackActions: {
+    replace: jest.fn((routeName: string) => ({
+      type: 'REPLACE',
+      routeName,
+    })),
+  },
 }));
 
 jest.mock('react-redux', () => ({
@@ -147,16 +160,18 @@ jest.mock('../../../../../../locales/i18n', () => ({
 }));
 
 describe('Complete Component', () => {
-  const mockNavigate = jest.fn();
   const mockDispatch = jest.fn();
   const mockTrackEvent = jest.fn();
   const mockCreateEventBuilder = jest.fn();
 
   beforeEach(() => {
     jest.clearAllMocks();
+    mockNavigationDispatch.mockClear();
+    mockStackReplace.mockClear();
+    (StackActions.replace as jest.Mock).mockImplementation(mockStackReplace);
 
     (useNavigation as jest.Mock).mockReturnValue({
-      navigate: mockNavigate,
+      dispatch: mockNavigationDispatch,
     });
 
     (useDispatch as jest.Mock).mockReturnValue(mockDispatch);
@@ -228,32 +243,56 @@ describe('Complete Component', () => {
       expect(button.props.disabled).toBeFalsy();
     });
 
-    it('navigates to card home when pressed', async () => {
+    it('dispatches replace action to card home when pressed', async () => {
       const { getByTestId } = render(<Complete />);
 
       const button = getByTestId('complete-confirm-button');
       fireEvent.press(button);
 
       await waitFor(() => {
-        expect(mockNavigate).toHaveBeenCalledWith('CardHome');
+        expect(mockStackReplace).toHaveBeenCalledWith(Routes.CARD.HOME);
+        expect(mockNavigationDispatch).toHaveBeenCalledWith(
+          expect.objectContaining({ routeName: Routes.CARD.HOME }),
+        );
       });
     });
 
-    it('calls navigate only once per button press', async () => {
+    it('dispatches replace action only once per button press', async () => {
       const { getByTestId } = render(<Complete />);
 
       const button = getByTestId('complete-confirm-button');
       fireEvent.press(button);
 
       await waitFor(() => {
-        expect(mockNavigate).toHaveBeenCalledTimes(1);
+        expect(mockNavigationDispatch).toHaveBeenCalledTimes(1);
       });
 
       fireEvent.press(button);
 
       await waitFor(() => {
-        expect(mockNavigate).toHaveBeenCalledTimes(2);
-        expect(mockNavigate).toHaveBeenCalledWith('CardHome');
+        expect(mockNavigationDispatch).toHaveBeenCalledTimes(2);
+        expect(mockStackReplace).toHaveBeenCalledWith(Routes.CARD.HOME);
+      });
+    });
+
+    it('falls back to authentication flow when token is missing', async () => {
+      const { getCardBaanxToken } = jest.requireMock(
+        '../../util/cardTokenVault',
+      );
+      getCardBaanxToken.mockResolvedValueOnce({
+        success: false,
+      });
+
+      const { getByTestId } = render(<Complete />);
+      fireEvent.press(getByTestId('complete-confirm-button'));
+
+      await waitFor(() => {
+        expect(mockStackReplace).toHaveBeenCalledWith(
+          Routes.CARD.AUTHENTICATION,
+        );
+        expect(mockNavigationDispatch).toHaveBeenCalledWith(
+          expect.objectContaining({ routeName: Routes.CARD.AUTHENTICATION }),
+        );
       });
     });
   });
@@ -265,14 +304,17 @@ describe('Complete Component', () => {
       expect(useNavigation).toHaveBeenCalledTimes(1);
     });
 
-    it('navigates to correct route on continue', async () => {
+    it('dispatches replace action to correct route on continue', async () => {
       const { getByTestId } = render(<Complete />);
 
       const button = getByTestId('complete-confirm-button');
       fireEvent.press(button);
 
       await waitFor(() => {
-        expect(mockNavigate).toHaveBeenCalledWith('CardHome');
+        expect(mockStackReplace).toHaveBeenCalledWith(Routes.CARD.HOME);
+        expect(mockNavigationDispatch).toHaveBeenCalledWith(
+          expect.objectContaining({ routeName: Routes.CARD.HOME }),
+        );
       });
     });
   });
@@ -403,7 +445,10 @@ describe('Complete Component', () => {
 
       // Verify navigation to final destination
       await waitFor(() => {
-        expect(mockNavigate).toHaveBeenCalledWith('CardHome');
+        expect(mockStackReplace).toHaveBeenCalledWith(Routes.CARD.HOME);
+        expect(mockNavigationDispatch).toHaveBeenCalledWith(
+          expect.objectContaining({ routeName: Routes.CARD.HOME }),
+        );
       });
     });
 
@@ -418,7 +463,10 @@ describe('Complete Component', () => {
       fireEvent.press(button);
 
       await waitFor(() => {
-        expect(mockNavigate).toHaveBeenCalledWith('CardHome');
+        expect(mockStackReplace).toHaveBeenCalledWith(Routes.CARD.HOME);
+        expect(mockNavigationDispatch).toHaveBeenCalledWith(
+          expect.objectContaining({ routeName: Routes.CARD.HOME }),
+        );
       });
     });
   });

app/components/UI/Card/components/Onboarding/Complete.test.tsx

@@ -1,5 +1,5 @@
 import React, { useEffect, useState } from 'react';
-import { useNavigation } from '@react-navigation/native';
+import { StackActions, useNavigation } from '@react-navigation/native';
 import OnboardingStep from './OnboardingStep';
 import { strings } from '../../../../../../locales/i18n';
 import Button, {
@@ -44,11 +44,12 @@ const Complete = () => {
     try {
       const token = await getCardBaanxToken();
       if (token.success && token.tokenData?.accessToken) {
-        navigation.navigate(Routes.CARD.HOME);
+        dispatch(resetOnboardingState());
+        navigation.dispatch(StackActions.replace(Routes.CARD.HOME));
       } else {
-        navigation.navigate(Routes.CARD.AUTHENTICATION);
+        dispatch(resetOnboardingState());
+        navigation.dispatch(StackActions.replace(Routes.CARD.AUTHENTICATION));
       }
-      dispatch(resetOnboardingState());
     } catch (error) {
       Logger.log('Complete::handleContinue error', error);
     } finally {