chore(sonarcloud): address sonarcloud code rating

Author: nickewansmith

app/components/UI/Perps/Views/PerpsClosePositionView/PerpsClosePositionView.tsx

@@ -227,6 +227,38 @@ const PerpsClosePositionView: React.FC = () => {
     orderAmount: closingValueString,
   });
 
+  // Determine reward animation state
+  const rewardAnimationState = useMemo(() => {
+    if (rewardsState.isLoading) {
+      return RewardAnimationState.Loading;
+    }
+    if (rewardsState.hasError) {
+      return RewardAnimationState.ErrorState;
+    }
+    return RewardAnimationState.Idle;
+  }, [rewardsState.isLoading, rewardsState.hasError]);
+
+  // Prepare tooltip data props conditionally
+  const tooltipDataProps = useMemo(() => {
+    if (selectedTooltip === 'closing_fees') {
+      return {
+        data: {
+          metamaskFeeRate: feeResults.metamaskFeeRate,
+          protocolFeeRate: feeResults.protocolFeeRate,
+          originalMetamaskFeeRate: feeResults.originalMetamaskFeeRate,
+          feeDiscountPercentage: feeResults.feeDiscountPercentage,
+        },
+      };
+    }
+    return {};
+  }, [
+    selectedTooltip,
+    feeResults.metamaskFeeRate,
+    feeResults.protocolFeeRate,
+    feeResults.originalMetamaskFeeRate,
+    feeResults.feeDiscountPercentage,
+  ]);
+
   // Calculate what user will receive (initial margin + P&L - fees)
   // P&L is already shown separately in the margin section as "includes P&L"
   const receiveAmount = useMemo(() => {
@@ -599,13 +631,7 @@ const PerpsClosePositionView: React.FC = () => {
                   strings('perps.points_error_content'),
                 )
               }
-              state={
-                rewardsState.isLoading
-                  ? RewardAnimationState.Loading
-                  : rewardsState.hasError
-                    ? RewardAnimationState.ErrorState
-                    : RewardAnimationState.Idle
-              }
+              state={rewardAnimationState}
             />
           </View>
         </View>
@@ -723,7 +749,7 @@ const PerpsClosePositionView: React.FC = () => {
         {filteredErrors.length > 0 && (
           <View style={styles.validationSection}>
             {filteredErrors.map((error, index) => (
-              <View key={index} style={styles.errorMessage}>
+              <View key={`error-${index}`} style={styles.errorMessage}>
                 <Icon
                   name={IconName.Danger}
                   size={IconSize.Sm}
@@ -847,16 +873,7 @@ const PerpsClosePositionView: React.FC = () => {
           onClose={handleTooltipClose}
           contentKey={selectedTooltip as PerpsTooltipContentKey}
           key={selectedTooltip}
-          {...(selectedTooltip === 'closing_fees'
-            ? {
-                data: {
-                  metamaskFeeRate: feeResults.metamaskFeeRate,
-                  protocolFeeRate: feeResults.protocolFeeRate,
-                  originalMetamaskFeeRate: feeResults.originalMetamaskFeeRate,
-                  feeDiscountPercentage: feeResults.feeDiscountPercentage,
-                },
-              }
-            : {})}
+          {...tooltipDataProps}
         />
       ) : null}
     </SafeAreaView>