Skip to content

Commit 3cf4f74

Browse files
authored
fix: update logic to support all non-evm chains cp-7.60.0 (#23328)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Update logic to include all non-evm chains when parsing deep link urls. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Update logic for deeplink parsing to take into account all non-EVM chains ## **Related issues** Fixes: #23314 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ x ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ x ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ x ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Generalizes asset metadata handling from Solana-only to all non-EVM chains using `isNonEvmChainId`. > > - **Bridge asset metadata utils (`app/components/UI/Bridge/hooks/useAssetMetadata/utils.ts`)**: > - Replace Solana-specific check with generic `isNonEvmChainId` for non-EVM asset handling in `fetchAssetMetadata`. > - Import `isNonEvmChainId` from `@metamask/bridge-controller` to support all non-EVM chains. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 2019411. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 3807955 commit 3cf4f74

File tree

1 file changed

+3
-2
lines changed
  • app/components/UI/Bridge/hooks/useAssetMetadata

1 file changed

+3
-2
lines changed

app/components/UI/Bridge/hooks/useAssetMetadata/utils.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import { handleFetch } from '@metamask/controller-utils';
1616
import {
1717
formatAddressToCaipReference,
1818
formatChainIdToHex,
19+
isNonEvmChainId,
1920
} from '@metamask/bridge-controller';
2021

2122
const TOKEN_API_V3_BASE_URL = 'https://tokens.api.cx.metamask.io/v3';
@@ -103,8 +104,8 @@ export const fetchAssetMetadata = async (
103104
assetId,
104105
};
105106

106-
// Solana
107-
if (chainId === MultichainNetwork.Solana && assetId) {
107+
// non-EVM
108+
if (isNonEvmChainId(chainId) && assetId) {
108109
const { assetReference } = parseCaipAssetType(assetId);
109110
return {
110111
...commonFields,

0 commit comments

Comments
 (0)