Skip to content

Commit 5c72dd9

Browse files
fix: fixes the network expansion tests (#17466)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Fixes the network expansion tests. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent f273db2 commit 5c72dd9

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

e2e/specs/assets/token-detection-import-all.spec.js renamed to e2e/specs/assets/token-detection-import-all.spec.ts

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,13 @@
22
import { loginToApp } from '../../viewHelper';
33
import { SmokeNetworkAbstractions } from '../../tags';
44
import WalletView from '../../pages/wallet/WalletView';
5-
import DetectedTokensView from '../../pages/wallet/DetectedTokensView';
6-
import Assertions from '../../utils/Assertions';
5+
import Assertions from '../../framework/Assertions';
76
import TestHelpers from '../../helpers';
8-
import FixtureBuilder from '../../fixtures/fixture-builder';
9-
import { withFixtures } from '../../fixtures/fixture-helper';
7+
import FixtureBuilder from '../../framework/fixtures/FixtureBuilder';
8+
import { withFixtures } from '../../framework/fixtures/FixtureHelper';
109

1110
const ETHEREUM_NAME = 'Ethereum';
12-
const USDC_NAME = 'USDC';
11+
const USDC_NAME = 'USDCoin';
1312

1413
describe(SmokeNetworkAbstractions('Import all tokens detected'), () => {
1514
beforeAll(async () => {
@@ -26,12 +25,12 @@ describe(SmokeNetworkAbstractions('Import all tokens detected'), () => {
2625
async () => {
2726
await loginToApp();
2827

29-
await Assertions.checkIfVisible(WalletView.container);
28+
await Assertions.expectElementToBeVisible(WalletView.container);
3029
const eth = WalletView.tokenInWallet(ETHEREUM_NAME);
3130
const usdc = WalletView.tokenInWallet(USDC_NAME);
3231

33-
await Assertions.checkIfVisible(eth);
34-
await Assertions.checkIfVisible(usdc);
32+
await Assertions.expectElementToBeVisible(eth);
33+
await Assertions.expectElementToBeVisible(usdc);
3534
},
3635
);
3736
});

0 commit comments

Comments
 (0)