Fix unit tests & lint

Author: OGPoyraz

app/components/Views/confirmations/hooks/useConfirmationRedesignEnabled.test.ts

@@ -26,12 +26,6 @@ const disabledFeatureFlags = {
   approve: false,
 };
 
-jest.mock('../../../../util/address', () => ({
-  ...jest.requireActual('../../../../util/address'),
-  isHardwareAccount: jest.fn(),
-  isExternalHardwareAccount: jest.fn(),
-}));
-
 jest.mock('../../../../core/Engine', () => ({
   getTotalEvmFiatAccountBalance: () => ({ tokenFiat: 10 }),
   context: {
@@ -53,11 +47,9 @@ describe('useConfirmationRedesignEnabled', () => {
   const confirmationRedesignFlagsMock = jest.mocked(
     selectConfirmationRedesignFlags,
   );
-  const isHardwareAccountMock = jest.mocked(isHardwareAccount);
 
   beforeEach(() => {
     jest.clearAllMocks();
-    isHardwareAccountMock.mockReturnValue(false);
     confirmationRedesignFlagsMock.mockReturnValue(disabledFeatureFlags);
   });
 
@@ -183,24 +175,6 @@ describe('useConfirmationRedesignEnabled', () => {
           expect(result.current.isRedesignedEnabled).toBe(false);
         });
 
-        it('returns true when from address is external hardware account', async () => {
-          confirmationRedesignFlagsMock.mockReturnValue({
-            ...disabledFeatureFlags,
-            signatures: true,
-            staking_confirmations: true,
-          });
-
-          isHardwareAccountMock.mockReturnValue(true);
-          const { result } = renderHookWithProvider(
-            useConfirmationRedesignEnabled,
-            {
-              state: stakingDepositConfirmationState,
-            },
-          );
-
-          expect(result.current.isRedesignedEnabled).toBe(true);
-        });
-
         it('only redesign if transactions is staking deposit', async () => {
           confirmationRedesignFlagsMock.mockReturnValue({
             ...disabledFeatureFlags,
@@ -344,27 +318,6 @@ describe('useConfirmationRedesignEnabled', () => {
     );
   });
 
-  it('if confirmation is a transaction, validates `txParams.from` is hardware account', () => {
-    isHardwareAccountMock.mockReturnValue(true);
-    confirmationRedesignFlagsMock.mockReturnValue({
-      ...disabledFeatureFlags,
-      transfer: true,
-    });
-
-    const { result } = renderHookWithProvider(useConfirmationRedesignEnabled, {
-      state: transferConfirmationState,
-    });
-
-    const expectedFromAddress =
-      transferConfirmationState.engine.backgroundState.TransactionController
-        .transactions[0].txParams.from;
-
-    expect(isHardwareAccountMock).toHaveBeenCalledTimes(1);
-    expect(isHardwareAccountMock).toHaveBeenCalledWith(expectedFromAddress);
-
-    expect(result.current.isRedesignedEnabled).toBe(false);
-  });
-
   it('returns false if transaction type is not in the list of redesigned transaction types', () => {
     const state = cloneDeep(approveERC20TransactionStateMock);
     state.engine.backgroundState.TransactionController.transactions[0].type =

app/components/Views/confirmations/hooks/useConfirmationRedesignEnabled.ts

@@ -96,8 +96,6 @@ export const useConfirmationRedesignEnabled = () => {
   const confirmationRedesignFlags = useSelector(
     selectConfirmationRedesignFlags,
   );
-  const fromAddress =
-    transactionMetadata?.txParams?.from ?? approvalRequest?.requestData?.from;
 
   const approvalRequestType = approvalRequest?.type as ApprovalType;
 
@@ -116,7 +114,6 @@ export const useConfirmationRedesignEnabled = () => {
     [
       approvalRequestType,
       confirmationRedesignFlags,
-      fromAddress,
       transactionMetadata,
     ],
   );