Skip to content

Commit 97fe703

Browse files
ccharlyccharly
authored
chore: bump eth-snap-keyring (to enable :accountCreated idempotency) cp-7.60.0 (#23310)
## **Description** Bumping `@metamask/eth-snap-keyring` to enable `notify:accountCreated` idempotency which is required by the Bitcoin Snap. This will reduce the number of "misaligned" warnings we had with Bitcoin. Similar to: - MetaMask/metamask-extension#38292 ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - #23324 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade `@metamask/eth-snap-keyring` to ^18.0.2 and refresh related keyring dependencies in `yarn.lock`. > > - **Dependencies**: > - Bump `@metamask/eth-snap-keyring` from `^18.0.0` to `^18.0.2` in `package.json`. > - Update lockfile to resolve to `18.0.2` and align transitive deps: > - `@metamask/keyring-api` -> `^21.2.0` > - `@metamask/keyring-internal-api` -> `9.1.1` > - `@metamask/keyring-internal-snap-client` -> `8.0.1` > - `@metamask/keyring-snap-client` -> `8.1.1` > - `@metamask/keyring-snap-sdk` -> `7.1.1` > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 02bd3bf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent ace4346 commit 97fe703

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,7 +223,7 @@
223223
"@metamask/eth-qr-keyring": "^1.1.0",
224224
"@metamask/eth-query": "^4.0.0",
225225
"@metamask/eth-sig-util": "^8.0.0",
226-
"@metamask/eth-snap-keyring": "^18.0.0",
226+
"@metamask/eth-snap-keyring": "^18.0.2",
227227
"@metamask/etherscan-link": "^2.0.0",
228228
"@metamask/ethjs-contract": "^0.4.1",
229229
"@metamask/ethjs-query": "^0.7.1",

‎yarn.lock‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -8160,25 +8160,25 @@ __metadata:
81608160
languageName: node
81618161
linkType: hard
81628162

8163-
"@metamask/eth-snap-keyring@npm:^18.0.0":
8164-
version: 18.0.0
8165-
resolution: "@metamask/eth-snap-keyring@npm:18.0.0"
8163+
"@metamask/eth-snap-keyring@npm:^18.0.0, @metamask/eth-snap-keyring@npm:^18.0.2":
8164+
version: 18.0.2
8165+
resolution: "@metamask/eth-snap-keyring@npm:18.0.2"
81668166
dependencies:
81678167
"@ethereumjs/tx": "npm:^5.4.0"
81688168
"@metamask/eth-sig-util": "npm:^8.2.0"
8169-
"@metamask/keyring-api": "npm:^21.1.0"
8170-
"@metamask/keyring-internal-api": "npm:^9.1.0"
8171-
"@metamask/keyring-internal-snap-client": "npm:^8.0.0"
8172-
"@metamask/keyring-snap-sdk": "npm:^7.1.0"
8169+
"@metamask/keyring-api": "npm:^21.2.0"
8170+
"@metamask/keyring-internal-api": "npm:^9.1.1"
8171+
"@metamask/keyring-internal-snap-client": "npm:^8.0.1"
8172+
"@metamask/keyring-snap-sdk": "npm:^7.1.1"
81738173
"@metamask/keyring-utils": "npm:^3.1.0"
81748174
"@metamask/messenger": "npm:^0.3.0"
81758175
"@metamask/superstruct": "npm:^3.1.0"
81768176
"@metamask/utils": "npm:^11.1.0"
81778177
"@types/uuid": "npm:^9.0.8"
81788178
uuid: "npm:^9.0.1"
81798179
peerDependencies:
8180-
"@metamask/keyring-api": ^21.1.0
8181-
checksum: 10/39a6380e351997e53776c8db9d1558769517a1a12ec1431c40cedb516d90ae447a81b7b1c21bc8d8ffcbc31188cf52f17057a1416d509013cfe8b2f46b314e02
8180+
"@metamask/keyring-api": ^21.2.0
8181+
checksum: 10/2c37e55cf4b56089fb5a081d3809b9004b8bbe2822267fbe5b8884cd687da4a43e122b053ebbc418173353232066a4763edc90002f51ce55a84e53a7009c16e6
81828182
languageName: node
81838183
linkType: hard
81848184

@@ -8391,7 +8391,7 @@ __metadata:
83918391
languageName: node
83928392
linkType: hard
83938393

8394-
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.1.0, @metamask/keyring-api@npm:^21.2.0":
8394+
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.2.0":
83958395
version: 21.2.0
83968396
resolution: "@metamask/keyring-api@npm:21.2.0"
83978397
dependencies:
@@ -8426,59 +8426,59 @@ __metadata:
84268426
languageName: node
84278427
linkType: hard
84288428

8429-
"@metamask/keyring-internal-api@npm:^9.0.0, @metamask/keyring-internal-api@npm:^9.1.0":
8430-
version: 9.1.0
8431-
resolution: "@metamask/keyring-internal-api@npm:9.1.0"
8429+
"@metamask/keyring-internal-api@npm:^9.0.0, @metamask/keyring-internal-api@npm:^9.1.0, @metamask/keyring-internal-api@npm:^9.1.1":
8430+
version: 9.1.1
8431+
resolution: "@metamask/keyring-internal-api@npm:9.1.1"
84328432
dependencies:
8433-
"@metamask/keyring-api": "npm:^21.1.0"
8433+
"@metamask/keyring-api": "npm:^21.2.0"
84348434
"@metamask/keyring-utils": "npm:^3.1.0"
84358435
"@metamask/superstruct": "npm:^3.1.0"
8436-
checksum: 10/6b19f35f57bc1b5dc73957d7f3185236780c93e6292678e22d84f9eb2fe92e15a98437a9bc4fbe5e5e10143d4db36afa2c420636f2cca4bd984e8455ca4332c6
8436+
checksum: 10/ab0fb8e153a02d3d0acf739d77356a1c60e0a7bf998dcbba9468f9f231605beaed472d8bff27dc56323d0a2529167336499e23dcad911fa8c3e37999ed14d2d1
84378437
languageName: node
84388438
linkType: hard
84398439

8440-
"@metamask/keyring-internal-snap-client@npm:^8.0.0":
8441-
version: 8.0.0
8442-
resolution: "@metamask/keyring-internal-snap-client@npm:8.0.0"
8440+
"@metamask/keyring-internal-snap-client@npm:^8.0.1":
8441+
version: 8.0.1
8442+
resolution: "@metamask/keyring-internal-snap-client@npm:8.0.1"
84438443
dependencies:
8444-
"@metamask/keyring-api": "npm:^21.1.0"
8445-
"@metamask/keyring-internal-api": "npm:^9.1.0"
8446-
"@metamask/keyring-snap-client": "npm:^8.1.0"
8444+
"@metamask/keyring-api": "npm:^21.2.0"
8445+
"@metamask/keyring-internal-api": "npm:^9.1.1"
8446+
"@metamask/keyring-snap-client": "npm:^8.1.1"
84478447
"@metamask/keyring-utils": "npm:^3.1.0"
84488448
"@metamask/messenger": "npm:^0.3.0"
8449-
checksum: 10/7a4aa08ac6ac1bda064182420af01b785aaaff37068d14577007ce40e53f4da33b3bbc1a18625ebd75cee6d08c34de8dc860e6c927477335d5f1df72328b563a
8449+
checksum: 10/40a686cd3d1f49accde83bb2a983ac9e897498e1de5a0ccb0768e382d44dd4c273230db95bcd6eace4ad8a184e7ab4fc780770f617994a2ca29b4302890f31b6
84508450
languageName: node
84518451
linkType: hard
84528452

8453-
"@metamask/keyring-snap-client@npm:^8.0.0, @metamask/keyring-snap-client@npm:^8.1.0":
8454-
version: 8.1.0
8455-
resolution: "@metamask/keyring-snap-client@npm:8.1.0"
8453+
"@metamask/keyring-snap-client@npm:^8.0.0, @metamask/keyring-snap-client@npm:^8.1.0, @metamask/keyring-snap-client@npm:^8.1.1":
8454+
version: 8.1.1
8455+
resolution: "@metamask/keyring-snap-client@npm:8.1.1"
84568456
dependencies:
8457-
"@metamask/keyring-api": "npm:^21.1.0"
8457+
"@metamask/keyring-api": "npm:^21.2.0"
84588458
"@metamask/keyring-utils": "npm:^3.1.0"
84598459
"@metamask/superstruct": "npm:^3.1.0"
84608460
"@types/uuid": "npm:^9.0.8"
84618461
uuid: "npm:^9.0.1"
84628462
webextension-polyfill: "npm:^0.12.0"
84638463
peerDependencies:
84648464
"@metamask/providers": ^19.0.0
8465-
checksum: 10/e92aa7f6e1454150870e8e0a6d9cf4fac7bbc22280d85a252ca7ee428842dfbaaaccae78dfc5ad773e21d757febfcbe6933a72b966c4478f1a2b3fc0088419a1
8465+
checksum: 10/dcdc9a286137a4ae884b709e565b988fb2e555a8a80db5d2ed3e93ee5262c81567a4efac6ff663b6751caf5b1173f92bc8437a395696058018a3b6e93fc30b35
84668466
languageName: node
84678467
linkType: hard
84688468

8469-
"@metamask/keyring-snap-sdk@npm:^7.1.0":
8470-
version: 7.1.0
8471-
resolution: "@metamask/keyring-snap-sdk@npm:7.1.0"
8469+
"@metamask/keyring-snap-sdk@npm:^7.1.1":
8470+
version: 7.1.1
8471+
resolution: "@metamask/keyring-snap-sdk@npm:7.1.1"
84728472
dependencies:
84738473
"@metamask/keyring-utils": "npm:^3.1.0"
84748474
"@metamask/snaps-sdk": "npm:^9.0.0"
84758475
"@metamask/superstruct": "npm:^3.1.0"
84768476
"@metamask/utils": "npm:^11.1.0"
84778477
webextension-polyfill: "npm:^0.12.0"
84788478
peerDependencies:
8479-
"@metamask/keyring-api": ^21.1.0
8479+
"@metamask/keyring-api": ^21.2.0
84808480
"@metamask/providers": ^19.0.0
8481-
checksum: 10/1a1809733c1f21af87f3491d292c499c5441afa0780e848718ec2b6aff50d76bb03ea44ee93ecaa80d79453a98926d84cd13ff406256ab6a2136d9e31250faa8
8481+
checksum: 10/ac4ce050f4647096ef66ebd04d99d1423c002ca0fb05bd83e11caec59754b56d73bb8a95ac3a76f64472713256205e889d6785003dfe2c35f5f1d67c2f2efd12
84828482
languageName: node
84838483
linkType: hard
84848484

@@ -35667,7 +35667,7 @@ __metadata:
3566735667
"@metamask/eth-qr-keyring": "npm:^1.1.0"
3566835668
"@metamask/eth-query": "npm:^4.0.0"
3566935669
"@metamask/eth-sig-util": "npm:^8.0.0"
35670-
"@metamask/eth-snap-keyring": "npm:^18.0.0"
35670+
"@metamask/eth-snap-keyring": "npm:^18.0.2"
3567135671
"@metamask/etherscan-link": "npm:^2.0.0"
3567235672
"@metamask/ethjs-contract": "npm:^0.4.1"
3567335673
"@metamask/ethjs-query": "npm:^0.7.1"

0 commit comments

Comments
 (0)