Skip to content

Commit ad906ab

Browse files
authored
chore(predict): cp-7.60.0 bump sell slippage to 3% (#23074)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Bump slippage for Sell orders to 3% (from 1.5%). This will help reducing the failure rate. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/PRED-327 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Increase sell-order slippage to 3% and introduce separate buy/sell slippage constants, applying them in order previews. > > - **Polymarket provider**: > - **Slippage constants**: Replace `SLIPPAGE` with `SLIPPAGE_BUY` (1.5%) and `SLIPPAGE_SELL` (3%) in `app/components/UI/Predict/providers/polymarket/constants.ts`. > - **Order preview**: In `app/components/UI/Predict/providers/polymarket/utils.ts`, use `SLIPPAGE_BUY` for buy previews and `SLIPPAGE_SELL` for sell previews; update imports accordingly. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 582821f. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent e850d9f commit ad906ab

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

app/components/UI/Predict/providers/polymarket/constants.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,8 @@ export const FEE_COLLECTOR_ADDRESS =
1111
/**
1212
* Default slippage for market orders.
1313
*/
14-
export const SLIPPAGE = 0.015; // 1.5%
14+
export const SLIPPAGE_BUY = 0.015; // 1.5%
15+
export const SLIPPAGE_SELL = 0.03; // 3%
1516

1617
export const ORDER_RATE_LIMIT_MS = 5000;
1718

app/components/UI/Predict/providers/polymarket/utils.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,14 +26,15 @@ import type {
2626
} from '../types';
2727
import {
2828
ClobAuthDomain,
29-
SLIPPAGE,
3029
EIP712Domain,
3130
FEE_PERCENTAGE,
3231
HASH_ZERO_BYTES32,
3332
MATIC_CONTRACTS,
3433
MSG_TO_SIGN,
3534
POLYGON_MAINNET_CHAIN_ID,
3635
ROUNDING_CONFIG,
36+
SLIPPAGE_BUY,
37+
SLIPPAGE_SELL,
3738
} from './constants';
3839
import { SafeFeeAuthorization } from './safe/types';
3940
import {
@@ -1151,7 +1152,7 @@ export const previewOrder = async (
11511152
sharePrice: bestPrice,
11521153
maxAmountSpent: makerAmount,
11531154
minAmountReceived: takerAmount,
1154-
slippage: SLIPPAGE,
1155+
slippage: SLIPPAGE_BUY,
11551156
tickSize: parseFloat(book.tick_size),
11561157
minOrderSize: parseFloat(book.min_order_size),
11571158
negRisk: book.neg_risk,
@@ -1184,7 +1185,7 @@ export const previewOrder = async (
11841185
sharePrice: bestPrice,
11851186
maxAmountSpent: makerAmount,
11861187
minAmountReceived: takerAmount,
1187-
slippage: SLIPPAGE,
1188+
slippage: SLIPPAGE_SELL,
11881189
tickSize: parseFloat(book.tick_size),
11891190
minOrderSize: parseFloat(book.min_order_size),
11901191
negRisk: book.neg_risk,

0 commit comments

Comments
 (0)