Skip to content

Commit b4dd0a7

Browse files
ccharlyccharly
committed
chore(runway): cherry-pick chore: bump eth-snap-keyring (to enable :accountCreated idempotency) cp-7.60.0 (#23310)
## **Description** Bumping `@metamask/eth-snap-keyring` to enable `notify:accountCreated` idempotency which is required by the Bitcoin Snap. This will reduce the number of "misaligned" warnings we had with Bitcoin. Similar to: - MetaMask/metamask-extension#38292 ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: - #23324 ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Upgrade `@metamask/eth-snap-keyring` to ^18.0.2 and refresh related keyring dependencies in `yarn.lock`. > > - **Dependencies**: > - Bump `@metamask/eth-snap-keyring` from `^18.0.0` to `^18.0.2` in `package.json`. > - Update lockfile to resolve to `18.0.2` and align transitive deps: > - `@metamask/keyring-api` -> `^21.2.0` > - `@metamask/keyring-internal-api` -> `9.1.1` > - `@metamask/keyring-internal-snap-client` -> `8.0.1` > - `@metamask/keyring-snap-client` -> `8.1.1` > - `@metamask/keyring-snap-sdk` -> `7.1.1` > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 02bd3bf. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 8f72c01 commit b4dd0a7

File tree

2 files changed

+34
-34
lines changed

2 files changed

+34
-34
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@
222222
"@metamask/eth-qr-keyring": "^1.1.0",
223223
"@metamask/eth-query": "^4.0.0",
224224
"@metamask/eth-sig-util": "^8.0.0",
225-
"@metamask/eth-snap-keyring": "^18.0.0",
225+
"@metamask/eth-snap-keyring": "^18.0.2",
226226
"@metamask/etherscan-link": "^2.0.0",
227227
"@metamask/ethjs-contract": "^0.4.1",
228228
"@metamask/ethjs-query": "^0.7.1",

‎yarn.lock‎

Lines changed: 33 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -7588,25 +7588,25 @@ __metadata:
75887588
languageName: node
75897589
linkType: hard
75907590

7591-
"@metamask/eth-snap-keyring@npm:^18.0.0":
7592-
version: 18.0.0
7593-
resolution: "@metamask/eth-snap-keyring@npm:18.0.0"
7591+
"@metamask/eth-snap-keyring@npm:^18.0.0, @metamask/eth-snap-keyring@npm:^18.0.2":
7592+
version: 18.0.2
7593+
resolution: "@metamask/eth-snap-keyring@npm:18.0.2"
75947594
dependencies:
75957595
"@ethereumjs/tx": "npm:^5.4.0"
75967596
"@metamask/eth-sig-util": "npm:^8.2.0"
7597-
"@metamask/keyring-api": "npm:^21.1.0"
7598-
"@metamask/keyring-internal-api": "npm:^9.1.0"
7599-
"@metamask/keyring-internal-snap-client": "npm:^8.0.0"
7600-
"@metamask/keyring-snap-sdk": "npm:^7.1.0"
7597+
"@metamask/keyring-api": "npm:^21.2.0"
7598+
"@metamask/keyring-internal-api": "npm:^9.1.1"
7599+
"@metamask/keyring-internal-snap-client": "npm:^8.0.1"
7600+
"@metamask/keyring-snap-sdk": "npm:^7.1.1"
76017601
"@metamask/keyring-utils": "npm:^3.1.0"
76027602
"@metamask/messenger": "npm:^0.3.0"
76037603
"@metamask/superstruct": "npm:^3.1.0"
76047604
"@metamask/utils": "npm:^11.1.0"
76057605
"@types/uuid": "npm:^9.0.8"
76067606
uuid: "npm:^9.0.1"
76077607
peerDependencies:
7608-
"@metamask/keyring-api": ^21.1.0
7609-
checksum: 10/39a6380e351997e53776c8db9d1558769517a1a12ec1431c40cedb516d90ae447a81b7b1c21bc8d8ffcbc31188cf52f17057a1416d509013cfe8b2f46b314e02
7608+
"@metamask/keyring-api": ^21.2.0
7609+
checksum: 10/2c37e55cf4b56089fb5a081d3809b9004b8bbe2822267fbe5b8884cd687da4a43e122b053ebbc418173353232066a4763edc90002f51ce55a84e53a7009c16e6
76107610
languageName: node
76117611
linkType: hard
76127612

@@ -7795,7 +7795,7 @@ __metadata:
77957795
languageName: node
77967796
linkType: hard
77977797

7798-
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.1.0, @metamask/keyring-api@npm:^21.2.0":
7798+
"@metamask/keyring-api@npm:^21.0.0, @metamask/keyring-api@npm:^21.2.0":
77997799
version: 21.2.0
78007800
resolution: "@metamask/keyring-api@npm:21.2.0"
78017801
dependencies:
@@ -7830,59 +7830,59 @@ __metadata:
78307830
languageName: node
78317831
linkType: hard
78327832

7833-
"@metamask/keyring-internal-api@npm:^9.0.0, @metamask/keyring-internal-api@npm:^9.1.0":
7834-
version: 9.1.0
7835-
resolution: "@metamask/keyring-internal-api@npm:9.1.0"
7833+
"@metamask/keyring-internal-api@npm:^9.0.0, @metamask/keyring-internal-api@npm:^9.1.0, @metamask/keyring-internal-api@npm:^9.1.1":
7834+
version: 9.1.1
7835+
resolution: "@metamask/keyring-internal-api@npm:9.1.1"
78367836
dependencies:
7837-
"@metamask/keyring-api": "npm:^21.1.0"
7837+
"@metamask/keyring-api": "npm:^21.2.0"
78387838
"@metamask/keyring-utils": "npm:^3.1.0"
78397839
"@metamask/superstruct": "npm:^3.1.0"
7840-
checksum: 10/6b19f35f57bc1b5dc73957d7f3185236780c93e6292678e22d84f9eb2fe92e15a98437a9bc4fbe5e5e10143d4db36afa2c420636f2cca4bd984e8455ca4332c6
7840+
checksum: 10/ab0fb8e153a02d3d0acf739d77356a1c60e0a7bf998dcbba9468f9f231605beaed472d8bff27dc56323d0a2529167336499e23dcad911fa8c3e37999ed14d2d1
78417841
languageName: node
78427842
linkType: hard
78437843

7844-
"@metamask/keyring-internal-snap-client@npm:^8.0.0":
7845-
version: 8.0.0
7846-
resolution: "@metamask/keyring-internal-snap-client@npm:8.0.0"
7844+
"@metamask/keyring-internal-snap-client@npm:^8.0.1":
7845+
version: 8.0.1
7846+
resolution: "@metamask/keyring-internal-snap-client@npm:8.0.1"
78477847
dependencies:
7848-
"@metamask/keyring-api": "npm:^21.1.0"
7849-
"@metamask/keyring-internal-api": "npm:^9.1.0"
7850-
"@metamask/keyring-snap-client": "npm:^8.1.0"
7848+
"@metamask/keyring-api": "npm:^21.2.0"
7849+
"@metamask/keyring-internal-api": "npm:^9.1.1"
7850+
"@metamask/keyring-snap-client": "npm:^8.1.1"
78517851
"@metamask/keyring-utils": "npm:^3.1.0"
78527852
"@metamask/messenger": "npm:^0.3.0"
7853-
checksum: 10/7a4aa08ac6ac1bda064182420af01b785aaaff37068d14577007ce40e53f4da33b3bbc1a18625ebd75cee6d08c34de8dc860e6c927477335d5f1df72328b563a
7853+
checksum: 10/40a686cd3d1f49accde83bb2a983ac9e897498e1de5a0ccb0768e382d44dd4c273230db95bcd6eace4ad8a184e7ab4fc780770f617994a2ca29b4302890f31b6
78547854
languageName: node
78557855
linkType: hard
78567856

7857-
"@metamask/keyring-snap-client@npm:^8.0.0, @metamask/keyring-snap-client@npm:^8.1.0":
7858-
version: 8.1.0
7859-
resolution: "@metamask/keyring-snap-client@npm:8.1.0"
7857+
"@metamask/keyring-snap-client@npm:^8.0.0, @metamask/keyring-snap-client@npm:^8.1.0, @metamask/keyring-snap-client@npm:^8.1.1":
7858+
version: 8.1.1
7859+
resolution: "@metamask/keyring-snap-client@npm:8.1.1"
78607860
dependencies:
7861-
"@metamask/keyring-api": "npm:^21.1.0"
7861+
"@metamask/keyring-api": "npm:^21.2.0"
78627862
"@metamask/keyring-utils": "npm:^3.1.0"
78637863
"@metamask/superstruct": "npm:^3.1.0"
78647864
"@types/uuid": "npm:^9.0.8"
78657865
uuid: "npm:^9.0.1"
78667866
webextension-polyfill: "npm:^0.12.0"
78677867
peerDependencies:
78687868
"@metamask/providers": ^19.0.0
7869-
checksum: 10/e92aa7f6e1454150870e8e0a6d9cf4fac7bbc22280d85a252ca7ee428842dfbaaaccae78dfc5ad773e21d757febfcbe6933a72b966c4478f1a2b3fc0088419a1
7869+
checksum: 10/dcdc9a286137a4ae884b709e565b988fb2e555a8a80db5d2ed3e93ee5262c81567a4efac6ff663b6751caf5b1173f92bc8437a395696058018a3b6e93fc30b35
78707870
languageName: node
78717871
linkType: hard
78727872

7873-
"@metamask/keyring-snap-sdk@npm:^7.1.0":
7874-
version: 7.1.0
7875-
resolution: "@metamask/keyring-snap-sdk@npm:7.1.0"
7873+
"@metamask/keyring-snap-sdk@npm:^7.1.1":
7874+
version: 7.1.1
7875+
resolution: "@metamask/keyring-snap-sdk@npm:7.1.1"
78767876
dependencies:
78777877
"@metamask/keyring-utils": "npm:^3.1.0"
78787878
"@metamask/snaps-sdk": "npm:^9.0.0"
78797879
"@metamask/superstruct": "npm:^3.1.0"
78807880
"@metamask/utils": "npm:^11.1.0"
78817881
webextension-polyfill: "npm:^0.12.0"
78827882
peerDependencies:
7883-
"@metamask/keyring-api": ^21.1.0
7883+
"@metamask/keyring-api": ^21.2.0
78847884
"@metamask/providers": ^19.0.0
7885-
checksum: 10/1a1809733c1f21af87f3491d292c499c5441afa0780e848718ec2b6aff50d76bb03ea44ee93ecaa80d79453a98926d84cd13ff406256ab6a2136d9e31250faa8
7885+
checksum: 10/ac4ce050f4647096ef66ebd04d99d1423c002ca0fb05bd83e11caec59754b56d73bb8a95ac3a76f64472713256205e889d6785003dfe2c35f5f1d67c2f2efd12
78867886
languageName: node
78877887
linkType: hard
78887888

@@ -34430,7 +34430,7 @@ __metadata:
3443034430
"@metamask/eth-qr-keyring": "npm:^1.1.0"
3443134431
"@metamask/eth-query": "npm:^4.0.0"
3443234432
"@metamask/eth-sig-util": "npm:^8.0.0"
34433-
"@metamask/eth-snap-keyring": "npm:^18.0.0"
34433+
"@metamask/eth-snap-keyring": "npm:^18.0.2"
3443434434
"@metamask/etherscan-link": "npm:^2.0.0"
3443534435
"@metamask/ethjs-contract": "npm:^0.4.1"
3443634436
"@metamask/ethjs-query": "npm:^0.7.1"

0 commit comments

Comments
 (0)