Skip to content

Commit b80d0ea

Browse files
test: disables flaky test (#19974)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Disables `e2e/specs/multichain/permissions/chains/permission-system-add-non-permitted.spec.js` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
1 parent 14c8e96 commit b80d0ea

File tree

1 file changed

+19
-19
lines changed

1 file changed

+19
-19
lines changed

e2e/specs/multichain/permissions/chains/permission-system-add-non-permitted.spec.js renamed to e2e/specs/quarantine/multichain/permissions/chains/permission-system-add-non-permitted.failing.js

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,25 +1,25 @@
11
import {
22
RegressionNetworkExpansion,
33
SmokeNetworkExpansion,
4-
} from '../../../../tags';
5-
import { loginToApp } from '../../../../viewHelper';
6-
import Assertions from '../../../../framework/Assertions';
7-
import TestHelpers from '../../../../helpers';
8-
import FixtureBuilder from '../../../../framework/fixtures/FixtureBuilder';
9-
import { withFixtures } from '../../../../framework/fixtures/FixtureHelper';
10-
import { CustomNetworks } from '../../../../resources/networks.e2e';
11-
import Browser from '../../../../pages/Browser/BrowserView';
12-
import TabBarComponent from '../../../../pages/wallet/TabBarComponent';
13-
import { NetworkNonPemittedBottomSheetSelectorsText } from '../../../../selectors/Network/NetworkNonPemittedBottomSheet.selectors';
14-
import ConnectedAccountsModal from '../../../../pages/Browser/ConnectedAccountsModal';
15-
import NetworkConnectMultiSelector from '../../../../pages/Browser/NetworkConnectMultiSelector';
16-
import { DappVariants } from '../../../../framework/Constants';
17-
import WalletView from '../../../../pages/wallet/WalletView';
18-
import NetworkListModal from '../../../../pages/Network/NetworkListModal';
19-
import NetworkEducationModal from '../../../../pages/Network/NetworkEducationModal';
20-
import NetworkNonPemittedBottomSheet from '../../../../pages/Network/NetworkNonPemittedBottomSheet';
21-
import TestDApp from '../../../../pages/Browser/TestDApp';
22-
import ConnectBottomSheet from '../../../../pages/Browser/ConnectBottomSheet';
4+
} from '../../../../../tags';
5+
import { loginToApp } from '../../../../../viewHelper';
6+
import Assertions from '../../../../../framework/Assertions';
7+
import TestHelpers from '../../../../../helpers';
8+
import FixtureBuilder from '../../../../../framework/fixtures/FixtureBuilder';
9+
import { withFixtures } from '../../../../../framework/fixtures/FixtureHelper';
10+
import { CustomNetworks } from '../../../../../resources/networks.e2e';
11+
import Browser from '../../../../../pages/Browser/BrowserView';
12+
import TabBarComponent from '../../../../../pages/wallet/TabBarComponent';
13+
import { NetworkNonPemittedBottomSheetSelectorsText } from '../../../../../selectors/Network/NetworkNonPemittedBottomSheet.selectors';
14+
import ConnectedAccountsModal from '../../../../../pages/Browser/ConnectedAccountsModal';
15+
import NetworkConnectMultiSelector from '../../../../../pages/Browser/NetworkConnectMultiSelector';
16+
import { DappVariants } from '../../../../../framework/Constants';
17+
import WalletView from '../../../../../pages/wallet/WalletView';
18+
import NetworkListModal from '../../../../../pages/Network/NetworkListModal';
19+
import NetworkEducationModal from '../../../../../pages/Network/NetworkEducationModal';
20+
import NetworkNonPemittedBottomSheet from '../../../../../pages/Network/NetworkNonPemittedBottomSheet';
21+
import TestDApp from '../../../../../pages/Browser/TestDApp';
22+
import ConnectBottomSheet from '../../../../../pages/Browser/ConnectBottomSheet';
2323

2424
const SEPOLIA = CustomNetworks.Sepolia.providerConfig.nickname;
2525
const ETHEREUM_MAIN_NET_NETWORK_NAME =

0 commit comments

Comments
 (0)