Skip to content

Commit c5465d6

Browse files
authored
fix(card): cp-7.59.0 delegation refresh issue (#22549)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR addresses two issues related to the Card feature and onboarding experience: - Delegation refresh issue: After completing a successful delegation, some data were not properly updated when navigating back to the CardHome screen. This fix ensures all relevant data refresh correctly to reflect the latest state. - KYC WebView permissions: Removed a property that was preventing the KYC WebView during onboarding from requesting camera and microphone access, restoring the expected behavior for KYC verification. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Data not refreshing properly on CardHome after successful delegation CHANGELOG entry: KYC WebView not requesting camera and microphone access during onboarding ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Adds a post-delegation delay and cache clear to refresh Card data, consolidates loading/navigation handling, removes token priority update, and re-enables KYC camera/mic prompts. > > - **Card — Spending Limit (`app/components/UI/Card/Views/SpendingLimit/SpendingLimit.tsx`)**: > - Aggregate loading state via `isProcessing` + `isDelegationLoading` (`isLoading`); block back/cancel while loading; update button `disabled`/`loading` states. > - On confirm: validate SDK (error toast if missing), submit delegation, wait 3s, `dispatch(clearCacheData('card-external-wallet-details'))`, show success toast, then navigate back. > - Remove token priority update flow and related utilities; simplify logic. > - **Tests (`SpendingLimit.test.tsx`)**: > - Remove token-priority mocks/tests; adjust expectations to await 3s delay, cache clear, success toast, and navigation. > - Add/modify loading and navigation blocking/cancel behavior tests. > - **Onboarding — KYC WebView (`app/components/UI/Card/components/Onboarding/KYCWebview.tsx`)**: > - Remove `mediaCapturePermissionGrantType` to allow camera/microphone permission prompts. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 4e1ae30. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent b6c100b commit c5465d6

File tree

3 files changed

+140
-436
lines changed

3 files changed

+140
-436
lines changed

0 commit comments

Comments
 (0)